V2

[paul-paliychuk]

Important

Add group management functionalities and update SDK version to 2.3.1, including new methods for listing, retrieving, and getting facts about groups.

• Behavior:
  • Add listAllGroups, getAGroup, and getFacts methods to Group class in src/api/resources/group/client/Client.ts.
  • Update SDK version to 2.3.1 in package.json, src/version.ts, and src/api/resources/document/client/Client.ts.
  • Add GetGroupsOrderedRequest type in src/api/resources/group/client/requests/GetGroupsOrderedRequest.ts.
• Models:
  • Add ApidataGroupListResponse model in src/api/types/ApidataGroupListResponse.ts.
  • Update Group model to include factRatingInstruction and groupId in src/api/types/Group.ts.
• Serialization:
  • Add ApidataGroupListResponse serializer in src/serialization/types/ApidataGroupListResponse.ts.
  • Update Group serializer to include factRatingInstruction and groupId in src/serialization/types/Group.ts.
• Misc:
  • Update .fernignore to include package.json and yarn.lock.
  • Unskip webpack test in tests/unit/fetcher/stream-wrappers/webpack.test.ts.

^{This description was created by for 098b833. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 098b833 in 1 minute and 12 seconds

More details

• Looked at 1365 lines of code in 22 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. tests/unit/fetcher/stream-wrappers/webpack.test.ts:3

• Draft comment:
  The describe.skip was removed, enabling this test. Ensure this change is intentional and the test is expected to pass.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR includes a change in the test file webpack.test.ts where a describe.skip was removed, enabling the test. This change should be acknowledged as it affects the test execution.

2. reference.md:2683

• Draft comment:
  Replace group_id with group ID for consistency and clarity. This applies to other instances in the file as well.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:

1. The term "group_id" appears in code examples and parameter names, which are technical contexts where underscores are common and appropriate. 2. In natural language descriptions, "group ID" would be more proper English. 3. However, this seems like a minor stylistic preference rather than a real issue. 4. Changing this could actually cause confusion since the code examples use group_id.
   The comment has a point about English style, but it could make documentation less consistent with the actual code, potentially confusing users.
   While proper English style would favor "group ID", maintaining consistency with code examples is more important for technical documentation.
   The comment should be deleted as it suggests a change that could reduce clarity by making documentation inconsistent with code examples.

Workflow ID: wflow_TupdhCUbRLVL6y0k

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.