Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional info for adding fred hutch as fnd #43

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

sckott
Copy link
Member

@sckott sckott commented Mar 11, 2025

In working on getwilds/sixtyfour#115 noticed that we do not have instructions in our guide on adding FH as funder to R and Python pkgs. So this PR adds that.

R

  • need a dev version of desc package - there's a new fxn to add ROR to person object -usethis::use_author doesn't have a way of adding a ROR (or ORCID, etc.)

Python

@sckott sckott requested review from seankross and tefirman March 11, 2025 18:23
Copy link

@sckott
Copy link
Member Author

sckott commented Mar 11, 2025

Copy link
Member

@seankross seankross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great and your reasoning is great. Thanks so much Scott.

@sckott
Copy link
Member Author

sckott commented Mar 11, 2025

thanks

@sckott sckott merged commit b1431f2 into main Mar 11, 2025
2 checks passed
@sckott sckott deleted the employer-author branch March 11, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants