-
Notifications
You must be signed in to change notification settings - Fork 111
yubico-authenticator: update to 7.3.0 #6404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ec0846b
to
0857731
Compare
I'm not fully sure about the approach to install |
I don't think using the |
The old way didn't work anymore, but I haven't looked into the new build script yet. |
It looks to be failing during the Flutter build; the helper builds fine with the old method. |
In my first try with the old helper build the package was built successfully, but the app failed loading the helper. The helper script is now developed using uv and has an We can avoid using the provided helper install script, although I'm not clear what the benefit would be. For other code build we also rely on the recommended build instructions and use the provided make commands. |
I tried extracting the helper build command from the helper install script, which works in principle. I recognized that the old Solus package was missing the helper license files, which could be a license violation (but I'm not an expert in this topic). build : |
# First, build the Python authentication helper
# Extract from build-helper.sh
export OUTPUT="$PWD/build/linux"
pushd helper
uv sync --locked
uv run --no-sync pyinstaller authenticator-helper.spec --distpath $OUTPUT
# Fixup permissions (should probably be more strict)
find $OUTPUT/helper -type f -exec chmod a-x {} +
chmod a+x $OUTPUT/helper/authenticator-helper
# Generating license files...
uv build
VENV="$OUTPUT/helper-license-venv"
uv run python -m venv $VENV
$VENV/bin/pip install --upgrade pip wheel
$VENV/bin/pip install dist/authenticator_helper-0.1.0-py3-none-any.whl pip-licenses
$VENV/bin/pip-licenses --format=json --no-license-path --with-license-file --ignore-packages authenticator-helper zxing-cpp --output-file ../assets/licenses/helper.json
popd
... |
0857731
to
2c4972b
Compare
If we want to build it with |
**Summary** - Release notes [here](https://github.com/Yubico/yubioath-flutter/releases/tag/7.3.0) - Corrected the package license - Removed some runtime dependencies
2c4972b
to
9a77eae
Compare
Would installing |
Summary
Test Plan
Installed locally, viewed accounts and passkey and added/removed a certificate.
Checklist