Skip to content

Conversation

@Jaredy899
Copy link
Contributor

@Jaredy899 Jaredy899 commented Sep 27, 2025

Summary

yazi: Add at 25.5.31

This is my first try at maintaining a package. Please let me know if anything needs to be added, changed, or deleted.

Resolves #6368

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

@github-project-automation github-project-automation bot moved this to Triage in Solus Sep 27, 2025
This was referenced Sep 27, 2025
Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thank you for trying to package this app. I must note that the usual workflow is the package request should be approved first before submitting a pull request. I will allow it this time but please keep that in mind.

As far the PR goes, this is a good first attempt. I have few notes:

packagename: Add at v1.0.0
  • The policy is that 1 package should in on 1 commit. So you should squash (Search for git squash) your commits into one.
  • If a package depends on another package that is not already on repositroy, that dependecy is automatically approved for inclusion too. Ideally it would included in the same pull request as the main package/app. I see that resvg is needed for yazi to display .svg file properly.
  • Please link the issue in the message if a pull request resolves something. In this case, this PR is resolving the package request. So, something like:
Resolves  https://github.com/getsolus/packages/issues/6368

Thanks again for being interested contributing to Solus. Feel free to ask any question here or in Matrix packaging room

@Jaredy899 Jaredy899 changed the title Yazi: initial package 25.5.31 Yazi: Add at v25.5.31 Sep 29, 2025
@Jaredy899
Copy link
Contributor Author

I appreciate the feedback! I believe I have made the appropriate changes and have squashed into one commit.

@Jaredy899
Copy link
Contributor Author

Since resvg is optional, would it be best to have it as a separate package? Not all other distros have resvg and Yazi still works without it but since it could be added, I decided to try.

Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still few things I missed:

  • Other distribution (Like Arch) ship ya binary too. Maybe we should do so. You can install multiple binary by passing the name of the binaries like this.
  • There are completions for bash, zsh and fish if YAZI_GEN_COMPLETIONS=true argument is passed on build steps. Example here.
  • Also install desktop file and icon in assets/ to appropriate directory. Example here. There is a bit of problem tho regarding the icon file, Yazi ship a non-standard size. I usually just chuck the non-standard size icon file to /usr/share/pixmaps but that directory is being phased out and should not be used anymore. You can use Imagemagick's magick command to resize the file dynamically like what they do on Arch.

I hope that is all. Thank you.

@Jaredy899 Jaredy899 requested a review from malfisya October 2, 2025 11:08
@Jaredy899
Copy link
Contributor Author

Thanks for the guidance. This should be closer to how Arch uses it and the icon and completion now appear.

@EbonJaeger EbonJaeger added the Topic: Sync Notes This PR/Issue can be highlighted in sync notes label Oct 2, 2025
@malfisya malfisya changed the title Yazi: Add at v25.5.31 yazi: Add at v25.5.31 Oct 3, 2025
Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, squash your commits again.

@Jaredy899 Jaredy899 force-pushed the add-yazi branch 2 times, most recently from 7cac9f3 to 0384e86 Compare October 4, 2025 13:52
@Jaredy899 Jaredy899 requested a review from malfisya October 4, 2025 13:54
Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one. There is stray new line on MAINTAINERS.md and monitoring.yaml. Please remove it. After this, I will merge it. Thank you.

**Summary**
Add Yazi, which is a blazing fast terminal file manager written in Rust, based on async I/O.

Resolves: getsolus#6368
Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Congratulations on your first contribution to Solus!

@malfisya malfisya merged commit 0444d31 into getsolus:main Oct 7, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Solus Oct 7, 2025
@Jaredy899 Jaredy899 deleted the add-yazi branch October 8, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Topic: Sync Notes This PR/Issue can be highlighted in sync notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Yazi

3 participants