-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: correct helper setup docs for bash and zsh #593
Conversation
Fix instructions for zsh and bash so helper functions work Add note that people with custom zsh configs need to adapt instructions Add example of what zshrc should contain Fixes #576
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ZSH instructions still do not work. To get it to work before, I had an extra line in my .zshrc
, I think given to me by @Staudey:
source "$HOME/.zshrc.d/solus-monorepo-helpers.zsh"
It went after autoload -U $HOME/.zshrc.d/*
. Whether or not that is the correct way to do things, I have no idea.
Yeah, I have two workarounds for this noted in my Either
Or
But as expected with the new instructions a simple
added to . |
Thanks for the feedback. After some reading, it is indeed necessary to source the helper script in I also changed the setup command a bit to make it easier to read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! It may be a few hours before I can deploy this, so if anyone else wants to before then, feel free.
Yoink |
Description
Fix instructions for zsh and bash so helper functions work Add note that people with custom zsh configs need to adapt instructions Add example of what zshrc should contain
Fixes #576
Testing
Verified solus helper commands can be run in a new shell session for both bash and zsh
For zsh, also created a test file in
~/.zshrc.d
and verified it was able to be run without specifying the path