Skip to content

Fix crate keywords and add a sigit-agent README after 1.7.0 - #245

Merged
setoelkahfi merged 3 commits into
developmentfrom
feature/fix-after-1.7.0
Oct 15, 2026
Merged

setoelkahfi merged 3 commits into
developmentfrom
feature/fix-after-1.7.0

Conversation

@setoelkahfi

Copy link
Copy Markdown
Collaborator

Follow-ups to the 1.7.0 release.

  • Trims the sigit crate keywords from eight to five. crates.io rejects more than five, which failed the tag-triggered publish of sigit 1.7.0. 1.7.0 was published by hand from this commit, so this brings development in line with what shipped.
  • Adds a README for sigit-agent and points readme at it. The crate had none, so its crates.io page was empty. It covers what the crate exports, serving SiGitCode in process, where the session lives and the environment variables it reads.

The README only shows on crates.io with the next published version, since 1.7.0 can't be changed.

cargo fmt -- --check, cargo clippy --tests -- -D warnings and cargo test --locked -p sigit-agent pass locally.

setoelkahfi and others added 2 commits October 15, 2026 15:39
The v1.7.0 publish of sigit failed with a 400 because the crate listed
eight keywords.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The crate had no readme, so its crates.io page was empty. This one covers
what the crate exports, how to serve SiGitCode in process, where the
session is stored and which environment variables it reads.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@sigit-code-review sigit-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes the crate keywords in crates/cli/Cargo.toml by reducing them from eight to five to comply with crates.io limits, aligning the development branch with the published 1.7.0 version. It also adds a new README file for the sigit-agent crate, describing its purpose, contents, usage example, session management, environment variables, and license. The sigit-agent/Cargo.toml is updated to point to this README. Review should focus on the correctness of the README content and the keyword adjustment to ensure no crates.io publishing issues remain.


Automated review by siGit Code Review · commit 3123b0b · see the review dashboard

Comment thread crates/cli/Cargo.toml
Comment thread crates/sigit-agent/README.md
@setoelkahfi
setoelkahfi requested a review from paydii October 15, 2026 13:41
@setoelkahfi setoelkahfi self-assigned this Oct 15, 2026
@setoelkahfi
setoelkahfi requested a review from keypair34 October 15, 2026 13:44
The example calls tokio::spawn, so a reader copying it needs a tokio
runtime. Say so under the snippet.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: siGit Code v1.6.9 <noreply@sigit.si>

@sigit-code-review sigit-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes the sigit crate keywords in crates/cli/Cargo.toml by reducing them from eight to five to comply with crates.io limits, aligning the development branch with the published 1.7.0 version. It also adds a detailed README for the sigit-agent crate, explaining its purpose, contents, usage example, session management, environment variables, and license. The sigit-agent crate's Cargo.toml is updated to point to this new README. Review should focus on the correctness of the README content, the example's dependency on tokio, and the keyword adjustment's impact on discoverability.


Automated review by siGit Code Review · commit ca20bf7 · see the review dashboard

Comment thread crates/sigit-agent/README.md

@sigit-code-review sigit-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side.

@setoelkahfi
setoelkahfi merged commit 549849c into development Oct 15, 2026
9 checks passed
@setoelkahfi
setoelkahfi deleted the feature/fix-after-1.7.0 branch October 15, 2026 20:04
@paydii paydii added the bug Something isn't working label Oct 18, 2026
@paydii paydii added this to the v1.7.1 milestone Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants