Repository navigation
ref(search): Merge list tools into search tools - #877
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Combine search_issues+list_issues, search_events+list_events, and search_issue_events+list_issue_events into single tools. Each tool now accepts both direct Sentry query syntax (via query/sort params) and optional natural language search (via naturalLanguageQuery param). When naturalLanguageQuery is provided and an embedded agent provider is configured, the agent refines the intent into correct Sentry params. When omitted, the direct params are used as-is with no agent overhead. This eliminates the mandatory agent round-trip for simple queries like iterating through N issues. Removes the AGENT_DEPENDENT_TOOLS/SIMPLE_REPLACEMENT_TOOLS mutual exclusivity system from server.ts. The 3 list_* tools and their directories are deleted. Tool count drops by 3. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Save and restore both OPENAI_API_KEY and ANTHROPIC_API_KEY in the ConfigurationError test teardown to prevent env var pollution across test runs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Clarify when search_events should choose errors, logs, or spans so the embedded agent treats error-severity logs as logs instead of exception events. Regenerate tool and skill definitions from the updated description. Co-Authored-By: Codex GPT-5 <codex@openai.com>
Keep direct-mode search parameters optional at TypeScript call sites and apply defaults inside the unified handlers. This preserves compatibility with natural language search calls after rebasing the merged search/list tools onto current main. Co-Authored-By: Codex GPT-5 <codex@openai.com>
dcramer
force-pushed
the
dcramer/ref/merge-search-list-tools
branch
from
April 28, 2026 18:22
f226f6a to
5c8fa84
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dcramer
force-pushed
the
dcramer/ref/merge-search-list-tools
branch
from
April 28, 2026 21:05
05559a9 to
9962824
Compare
dcramer
force-pushed
the
dcramer/ref/merge-search-list-tools
branch
from
April 28, 2026 21:21
9962824 to
c21f8d6
Compare
dcramer
marked this pull request as ready for review
April 28, 2026 21:36
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collapse natural language search input into the existing query parameter and run configured agent providers as a repair pass over query, dataset, fields, sort, and time hints. Update generated definitions, docs, evals, and tests so search tools expose query as the single input for both natural language and direct Sentry syntax. Co-Authored-By: Codex GPT-5 <codex@openai.com>
dcramer
force-pushed
the
dcramer/ref/merge-search-list-tools
branch
from
April 28, 2026 21:53
c21f8d6 to
6181581
Compare
dcramer
changed the title
Document embedded search agents as a structured parameter repair step instead of only natural-language query translation. Clarify that direct-capable tools should skip the repair step when no usable provider is available, while selected provider API failures should surface as user-facing LLM provider errors. Co-Authored-By: GPT-5 Codex <codex@openai.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Avoid adding the default replay statsPeriod when the search repair agent returns an absolute start/end time range. Sending both relative and absolute time filters can cause replay searches to ignore the requested absolute window. Add regression coverage for replay searches to assert start/end are sent without statsPeriod. Co-Authored-By: GPT-5 Codex <codex@openai.com>
3 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the old list/search split into three unified search tools:
search_issues,search_events, andsearch_issue_events. The removedlist_issues,list_events, andlist_issue_eventsbehavior is now available through directqueryand filter parameters on those search tools, reducing the default tool surface by three tools.Search agent usage is now framed as structured parameter repair rather than only query translation. Without an embedded agent provider, the tools execute direct Sentry query syntax and explicit parameters as-is. With a provider configured, the same request can include natural language or Sentry syntax, and the repair pass can correct the query plus related parameters such as dataset, fields, sort, and time range while preserving valid explicit inputs.
The search schemas now use
queryinstead ofnaturalLanguageQuery, keep direct parameters optional where listing recent results makes sense, and improvesearch_eventsdataset guidance. In particular, log-related requests route to the logs dataset even when severity is error or warning, while exception/crash issue data stays under errors.Generated tool/skill definitions, evals, docs, plugin agent prompts, and trace/profile follow-up guidance have been updated to point at the unified search tools.
docs/adding-tools.mdnow documents the agent-in-tool pattern as parameter repair, including the no-provider fallback and user-facing provider error behavior.