Repository navigation
Conversation
| pnpm = package_json["packageManager"] | ||
| pnpm_version = pnpm.split("@")[-1] | ||
|
|
||
| # TODO: move pnpm install into devenv |
There was a problem hiding this comment.
i've been procrastinating a bit on https://linear.app/getsentry/issue/DI-1012/devenv-install-pnpm but since more repos are using pnpm i'll probably get around to it next week!
There was a problem hiding this comment.
will update this PR after getsentry/devenv#210 gets merged + new release!
|
I'd prefer to avoid complexity in this project - devenv is only used by sentry internally and we're trying to keep this with easy to operate industry tools whats this get us that we're missing today? |
|
it automatically installs the pinned pnpm version in otherwise you can install and manage pnpm yourself but letting devenv handle it helps us ensure consistency and repeatabilty across dev+ci environments |
|
I'm going to say we wont do this. Happy to make it optional (right now it basically makes it the default way), but devenv is a global installation on machines and we're already using industry standard dev environment practices for this repo. I dont want to require third party contributors to setup a Sentry specific tool when its not needed. |
2 participants
assuming devenv is already installed globally:
...performs an isolated node+pnpm install independent of the system