Skip to content

Adopt Oxc lint and format tooling for MCP and root - #1419

Merged
BYK merged 9 commits into
mainfrom
chore/oxlint-oxfmt
Oct 6, 2026
Merged

BYK merged 9 commits into
mainfrom
chore/oxlint-oxfmt

Conversation

@BYK

@BYK BYK commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Adopt Oxlint and Oxfmt for MCP and root files while preserving CLI Biome, its Grit rules, and staged-file checks.
  • Keep Oxlint’s default correctness plugins enabled alongside accessibility rules. Use Oxc’s shipped language server for root/MCP editor formatting and fixes; document CLI’s separate Biome formatting path.
  • Add regressions for plugin and editor settings. Fix the terminal animation’s keyboard replay on its final step, with a regression that fails before the fix and when the guard is removed.
  • Preserve the intentional ASCII-control token-padding check with a narrow lint suppression.

Validation

  • Root script tests: 30 passed. Toolkit-core tests: 3 passed. Cloudflare tests: 433 passed across 34 files. Combined-tree typecheck, lint, docs links, and Oxfmt checks passed.
  • The local root pnpm run test reached the 15-minute limit during the CLI suite; no passing aggregate result is claimed. Exact-head CI runs the workspace tests independently.

BYK and others added 2 commits October 5, 2026 18:05
Co-Authored-By: GPT-6 Sol <agent@openai.com>
Keep the CLI's Biome rules until their custom Grit checks have equivalents. Run Oxfmt and Oxlint for the remaining workspaces, and preserve accessibility linting and staged-file isolation.

Co-Authored-By: GPT-6 Sol <agent@openai.com>

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread .oxlintrc.json Outdated
BYK and others added 2 commits October 5, 2026 21:29
Update tracked skill frontmatter in Craft's post-release version bump without depending on the ignored API schema or a network fetch. Exercise the real script with isolated npm and git stubs to prove the files change before the commit.

Co-Authored-By: GPT-6 Sol <agent@openai.com>
@github-actions github-actions Bot added the risk: low PR risk score: low label Oct 5, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d39c63b. Configure here.

Comment thread .vscode/extensions.json
Base automatically changed from fix/cli-skill-version to main October 6, 2026 07:02
BYK and others added 3 commits October 6, 2026 07:51
Co-Authored-By: GPT-6 Sol <agent@openai.com>
Co-Authored-By: GPT-6 Sol <agent@openai.com>
Co-Authored-By: GPT-6 Sol <agent@openai.com>
@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: low PR risk score: low labels Oct 6, 2026
Comment thread pnpm-workspace.yaml
@BYK
BYK merged commit 8b63210 into main Oct 6, 2026
34 checks passed
@BYK
BYK deleted the chore/oxlint-oxfmt branch October 6, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant