Skip to content

fix(search-events): stop silent full-text downgrades #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcramer merged 8 commits into from
Aug 16, 2026
Merged

fix(search-events): stop silent full-text downgrades #1252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2f3cf48
fix(search-events): reject silent full-text filter downgrades
sentry-junior[bot] Aug 15, 2026
a1f46de
fix(search-events): mvp reject message full-text filter downgrades
sentry-junior[bot] Aug 15, 2026
ee35b80
refactor(search-events): one agent pass with validateSearch tool
sentry-junior[bot] Aug 15, 2026
bd4012c
fix(search-events): ignore message: inside quoted filter values
sentry-junior[bot] Aug 15, 2026
68df4d4
fix(search-events): catch multiset structured filter downgrades
sentry-junior[bot] Aug 15, 2026
bbd9933
fix(search-events): parse full quoted filter values in downgrade guard
sentry-junior[bot] Aug 15, 2026
fadd97a
fix(search-events): match downgrade values as whole tokens
sentry-junior[bot] Aug 15, 2026
99bf5c6
test(search-events): assert IO behavior instead of prompt text
sentry-junior[bot] Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/testing/overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Our testing approach prioritizes **functional coverage** over implementation det
- Standard library behavior (Promise.all, Array.map, etc.)
- Third-party package internals (Zod validation, MSW mocking, etc.)
- Implementation details (private methods, internal state)
- Agent/system prompt text or prompt wording (assert behavior via tool inputs/outputs and Sentry API requests instead)
- Obvious behavior that will break immediately if wrong

### Example: Context Passing
Expand Down
Loading
Loading