Skip to content

feat(action): Add sentry-python-path input#28

Merged
alexander-alderman-webb merged 1 commit into
mainfrom
webb/sentry-python-path
Jan 20, 2026
Merged

feat(action): Add sentry-python-path input#28
alexander-alderman-webb merged 1 commit into
mainfrom
webb/sentry-python-path

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

No description provided.

@alexander-alderman-webb alexander-alderman-webb merged commit dba21cb into main Jan 20, 2026
9 checks passed
Comment thread action.yml
sentry-python-path:
description: "Path to local sentry-python repository"
required: false
default: "../../../sentry-python/sentry-python"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The default value for sentry-python-path in action.yml is ../../../sentry-python/sentry-python, which contains an extra, incorrect /sentry-python suffix, causing path validation to fail.
Severity: HIGH

Suggested Fix

In action.yml, change the default value for the sentry-python-path input from ../../../sentry-python/sentry-python to ../../../sentry-python. This will align the default path with the validation logic's expectation that setup.py exists at the root of the specified directory.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: action.yml#L17

Potential issue: The default path for the `sentry-python-path` input in `action.yml` is
set to `../../../sentry-python/sentry-python`. This path is incorrect because it
contains a redundant `/sentry-python` suffix. The validation logic in
`shared/orchestration/src/setup.ts` expects to find a `setup.py` file and a
`sentry_sdk/` directory at the root of the provided path. Due to the incorrect default,
the validation fails because it looks for these files in a non-existent nested
directory, leading to a `"✗ Local Sentry SDK path missing setup.py"` error. This breaks
the local Python SDK setup feature for any user relying on the default path.

Did we get this right? 👍 / 👎 to inform future reviews.

@github-actions

Copy link
Copy Markdown

🟡 AI SDK Integration Test Results

Status: 1 test fixed, 36 still failing

Summary

Metric main PR Change
Total Tests 56 56
Passed 19 20 +1 ✅
Failed 37 36 -1 ✅

✅ Fixed

These tests were failing on main but are now passing:

  • js/google-genai :: 9-message-truncation

Test Matrix

SDK 1-simple 10-binary-content-redaction 2-multi-step 9-message-truncation
js/anthropic
js/google-genai ✅🔧
js/langchain
js/langgraph
js/openai
js/vercel
py/anthropic
py/google-genai
py/langchain
py/langgraph
py/litellm
py/openai
py/openai-agents
py/pydantic-ai

Legend: ✅ Pass | ❌ Fail | ✅🔧 Fixed | ❌📉 Regressed | ✅🆕 New (pass) | ❌🆕 New (fail) | 🗑️ Removed


Generated by AI SDK Integration Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant