feat(action): Add sentry-python-path input#28
Conversation
| sentry-python-path: | ||
| description: "Path to local sentry-python repository" | ||
| required: false | ||
| default: "../../../sentry-python/sentry-python" |
There was a problem hiding this comment.
Bug: The default value for sentry-python-path in action.yml is ../../../sentry-python/sentry-python, which contains an extra, incorrect /sentry-python suffix, causing path validation to fail.
Severity: HIGH
Suggested Fix
In action.yml, change the default value for the sentry-python-path input from ../../../sentry-python/sentry-python to ../../../sentry-python. This will align the default path with the validation logic's expectation that setup.py exists at the root of the specified directory.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: action.yml#L17
Potential issue: The default path for the `sentry-python-path` input in `action.yml` is
set to `../../../sentry-python/sentry-python`. This path is incorrect because it
contains a redundant `/sentry-python` suffix. The validation logic in
`shared/orchestration/src/setup.ts` expects to find a `setup.py` file and a
`sentry_sdk/` directory at the root of the provided path. Due to the incorrect default,
the validation fails because it looks for these files in a non-existent nested
directory, leading to a `"✗ Local Sentry SDK path missing setup.py"` error. This breaks
the local Python SDK setup feature for any user relying on the default path.
Did we get this right? 👍 / 👎 to inform future reviews.
🟡 AI SDK Integration Test ResultsStatus: 1 test fixed, 36 still failing Summary
✅ FixedThese tests were failing on main but are now passing:
Test Matrix
Legend: ✅ Pass | ❌ Fail | ✅🔧 Fixed | ❌📉 Regressed | ✅🆕 New (pass) | ❌🆕 New (fail) | 🗑️ Removed Generated by AI SDK Integration Tests |
No description provided.