-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Ensure ports are confirmed free before allocation in Cloudflare and Python runners #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
constantinius
merged 1 commit into
main
from
constantinius/fix/cloudflare/port-conflict
Apr 28, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,40 @@ | ||
| /** | ||
| * Shared port allocator for test runners. | ||
| * Assigns unique ports to avoid collisions when running tests in parallel. | ||
| * | ||
| * Probes each candidate port with a temporary TCP server to ensure it is | ||
| * actually free before handing it out. | ||
| */ | ||
|
|
||
| import * as net from "net"; | ||
|
|
||
| let nextPort = 10000 + Math.floor(Math.random() * 40000); | ||
|
|
||
| export function allocatePort(): number { | ||
| return nextPort++; | ||
| /** | ||
| * Check whether a port is available by briefly binding to it. | ||
| * Binds on both IPv4 and IPv6 loopback to match what most servers do. | ||
| */ | ||
| function isPortFree(port: number): Promise<boolean> { | ||
| return new Promise((resolve) => { | ||
| const server = net.createServer(); | ||
| server.unref(); | ||
| server.on("error", () => resolve(false)); | ||
| server.listen(port, "0.0.0.0", () => { | ||
| server.close(() => resolve(true)); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Allocate a port that is confirmed free at the moment of allocation. | ||
| * Tries up to 200 sequential candidates before giving up. | ||
| */ | ||
| export async function allocatePort(): Promise<number> { | ||
| for (let attempts = 0; attempts < 200; attempts++) { | ||
| const candidate = nextPort++; | ||
| if (await isPortFree(candidate)) { | ||
| return candidate; | ||
| } | ||
| } | ||
| throw new Error("Failed to find a free port after 200 attempts"); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment claims IPv6 check but code only checks IPv4
Medium Severity
The JSDoc for
isPortFreestates it "Binds on both IPv4 and IPv6 loopback to match what most servers do," but the implementation only callsserver.listen(port, "0.0.0.0", ...), which binds exclusively on IPv4 all-interfaces (not even loopback). No IPv6 check (e.g., on::or::1) is performed. On systems wherelocalhostresolves to::1first (common on modern Linux/macOS), a port occupied on IPv6 would be reported as free, defeating the purpose of this PR.Reviewed by Cursor Bugbot for commit e2f2b03. Configure here.