-
-
Notifications
You must be signed in to change notification settings - Fork 85
feat(debuginfo): Extract srcsrv data from PDB for file mapping #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
ebdbaee
feat(debuginfo): Extract srcsrv data from PDB for file mapping
mujacica e832235
Add srcsrv to pdb
mujacica 2a0e0d8
Cleanup implementation
mujacica b234ddb
Fix format/changelog
mujacica 8fff473
Fix path handling
mujacica b7cb2d1
Don't prepend
mujacica 12a41bb
Rework to use PdbDebugSession
mujacica 2c8521f
Revert the rest of the files
mujacica f9f84e1
Support function iterator
mujacica 63ef28c
Review comments
mujacica 8262b0e
Update symbolic-debuginfo/src/pdb.rs
mujacica 1ca76a3
Update symbolic-debuginfo/src/pdb.rs
mujacica a5afa5e
Extract the revision and support both formats
mujacica 6b9f3c1
Rework based on feedback from Sebastian
mujacica 6290cd3
Remove unused import
mujacica d879081
Merge branch 'master' into feat/perforce-srcsrv-support
loewenheim 524623f
Remove orphaned modules
loewenheim 72df305
Refactor
loewenheim 6fbf4ec
Put srcsrv information besides original instead of overwriting
loewenheim 2c2c298
Remove function
loewenheim bcc01e1
Expand Perforce variant documentation
loewenheim 1f3e73c
Document when parsing SourceServerMappings fails
loewenheim 9603f9e
Typo
loewenheim e3e841a
Fix doc link
loewenheim 4ef2e49
More minor corrections
loewenheim 9b2ff63
Move "no vcs" error
loewenheim c6ff18f
Don't error when failing to open srcsrv data
loewenheim c9e477e
correct some comments
loewenheim 6f86859
Don't needlessly use pub(crate)
loewenheim 7639205
Prefix revision with srcsrv
loewenheim 5cbc898
Simplify tests
loewenheim a93142c
Add unit test
loewenheim ac444aa
Merge branch 'master' into feat/perforce-srcsrv-support
loewenheim ed90fde
Fixup test_cache.rs
loewenheim d0a2953
Expand comment
loewenheim c144b3b
Some more doc comments
loewenheim 0fbed54
Merge branch 'master' into feat/perforce-srcsrv-support
loewenheim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.