fix(inc984): scrub the correct bucket for sentry.user #6693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volokluev
reviewed
Dec 19, 2024
xurui-c
force-pushed
the
rachel/fixBucket
branch
from
f2924f0 to
966591a
Compare
volokluev
reviewed
Dec 19, 2024
Comment on lines
-188
to
-189
| "user.ip": "192.168.0.45", | ||
| "user": user, |
There was a problem hiding this comment.
shouldn't this be inside sentry_tags?
There was a problem hiding this comment.
I feel like user.ip is tested in test_scrub_user_ip_from_eap_spans alr
volokluev
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
userfield is sent in the sentry_tags dictionary which is prefixed with sentry automatically in the message processor. thus, a different attribute column has to be scrubbed