fix(coding-conventions): Resolve static-component-definitions in progressActivityTooltip#120045
Open
sentry[bot] wants to merge 2 commits into
Open
fix(coding-conventions): Resolve static-component-definitions in progressActivityTooltip#120045sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
…ressActivityTooltip
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introduced
This is informational only and does not block the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
static-component-definitionslinting error occurring instatic/app/views/issueList/progressActivityTooltip.tsx.Problem:
The
ProgressActivityItemcomponent was dynamically creating a React component type during its render cycle. Specifically, thecomponentFunctionwithingroupActivityTypeIconMapping(defined ingroupActivityIcons.tsx) for certain activity types (likeGroupActivityType.NOTE) was returning a new inline function component on every render. When this dynamically generated component type was then used as a JSX element (<Icon />), React would treat it as a new component on each render, leading to unnecessary unmounting/remounting of its subtree and preventing React Compiler optimizations.Solution:
renderActivityIcon, ingroupActivityIcons.tsx. This function now directly returns aReactNode(JSX) by usingcreateElementfromreact, rather than returning a component type. This ensures that the actual component rendering is handled by a stable, module-scoped function.progressActivityTooltip.tsx: TheProgressActivityItemcomponent now callsrenderActivityIcondirectly, passing theiconMapping,itemdata, and any additional icon props. This eliminates the need for the intermediateIconvariable that previously held the dynamically created component type.GroupActivityType.NOTE: ForGroupActivityType.NOTE, thecomponentFunctionin theiconMappingis explicitly set toundefinedin theeffectiveMappingpassed torenderActivityIcon. This ensures thatrenderActivityIconfalls back to the staticIconChatcomponent or renders the avatar directly, preventing the dynamic component creation.import React from 'react'toimport {createElement} from 'react'ingroupActivityIcons.tsxto align with codebase conventions that favor named imports over defaultReactimports for specific utilities.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-36D
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.