fix(feedbackModal): Resolve static-component-definitions violation#120041
Open
sentry[bot] wants to merge 2 commits into
Open
fix(feedbackModal): Resolve static-component-definitions violation#120041sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introduced
This is informational only and does not block the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
static-component-definitionsReact Compiler diagnostic infeedbackModal.tsx.The
ModalHeader,ModalBody, andModalFootercomponents were previously defined usinguseCallbackwithin theFeedbackModal's render function. This pattern causes React to treat them as new components on each render, leading to state loss and blocking compiler optimizations.To fix this, these components have been extracted to module scope. Their dynamic dependencies (such as
Header,Body,FooterfromModalRenderProps,closeModal,handleSubmit,isSelfHosted,isScreenSmall, andstate) are now provided via a newFeedbackModalContext. This ensures the components have stable identities across renders while still receiving necessary dynamic data.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-355
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.