Skip to content

fix(structuredEventData): Remove inline Wrapper component in RecursiveStructuredData #120038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryan953 merged 1 commit into from
Jul 20, 2026
+21 −23
Merged

fix(structuredEventData): Remove inline Wrapper component in RecursiveStructuredData #120038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 21 additions & 23 deletions static/app/components/structuredEventData/recursiveStructuredData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,12 @@ export function RecursiveStructuredData({
</Fragment>
);

function Wrapper({children}: {children: React.ReactNode}) {
return (
<Fragment>
{formattedObjectKey}
{children}
</Fragment>
);
}

if (config?.isNull?.(value) || value === null) {
const nullValue = config?.renderNull?.(value) ?? String(value);

return (
<Wrapper>
<Fragment>
{formattedObjectKey}
<ValueNull data-test-id="value-null">
<AnnotatedValue
value={nullValue}
Expand All @@ -79,15 +71,16 @@ export function RecursiveStructuredData({
withOnlyFormattedText={withOnlyFormattedText}
/>
</ValueNull>
</Wrapper>
</Fragment>
);
}

if (config?.isBoolean?.(value) || value === true || value === false) {
const booleanValue = config?.renderBoolean?.(value) ?? String(value);

return (
<Wrapper>
<Fragment>
{formattedObjectKey}
<ValueBoolean data-test-id="value-boolean">
<AnnotatedValue
value={booleanValue}
Expand All @@ -96,13 +89,14 @@ export function RecursiveStructuredData({
withOnlyFormattedText={withOnlyFormattedText}
/>
</ValueBoolean>
</Wrapper>
</Fragment>
);
}

if (typeof value === 'number' || config?.isNumber?.(value)) {
return (
<Wrapper>
<Fragment>
{formattedObjectKey}
<ValueNumber data-test-id="value-number">
<AnnotatedValue
value={value}
Expand All @@ -111,7 +105,7 @@ export function RecursiveStructuredData({
withOnlyFormattedText={withOnlyFormattedText}
/>
</ValueNumber>
</Wrapper>
</Fragment>
);
}

Expand All @@ -120,7 +114,8 @@ export function RecursiveStructuredData({
const stringValue = config.renderString?.(value) ?? value;

return (
<Wrapper>
<Fragment>
{formattedObjectKey}
<ValueString data-test-id="value-string">
{'"'}
<AnnotatedValue
Expand All @@ -132,13 +127,14 @@ export function RecursiveStructuredData({
{'"'}
<LinkHint meta={meta} value={stringValue} />
</ValueString>
</Wrapper>
</Fragment>
);
}

if (looksLikeStrippedValue(value)) {
return (
<Wrapper>
<Fragment>
{formattedObjectKey}
<ValueStrippedString>
<AnnotatedValue
value={value}
Expand All @@ -147,13 +143,14 @@ export function RecursiveStructuredData({
withOnlyFormattedText={withOnlyFormattedText}
/>
</ValueStrippedString>
</Wrapper>
</Fragment>
);
}

if (containsCRLF(value)) {
return (
<Wrapper>
<Fragment>
{formattedObjectKey}
<ValueMultiLineString data-test-id="value-multiline-string">
<AnnotatedValue
value={value}
Expand All @@ -162,12 +159,13 @@ export function RecursiveStructuredData({
withOnlyFormattedText={withOnlyFormattedText}
/>
</ValueMultiLineString>
</Wrapper>
</Fragment>
);
}

return (
<Wrapper>
<Fragment>
{formattedObjectKey}
<span data-test-id="value-unformatted">
<AnnotatedValue
value={value}
Expand All @@ -177,7 +175,7 @@ export function RecursiveStructuredData({
/>
<LinkHint meta={meta} value={value} />
</span>
</Wrapper>
</Fragment>
);
}

Expand Down
Loading