Skip to content

fix(dashboards): Resolve static-component-definitions in GenericFilterSelector #120033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(dashboards): Resolve static-component-definitions in GenericFilterSelector #120033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 9 additions & 19 deletions static/app/views/dashboards/globalFilter/genericFilterSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,27 +13,17 @@ export type GenericFilterSelectorProps = {
disableRemoveFilter?: boolean;
};

function getFilterSelector(
globalFilter: GlobalFilter
): React.ComponentType<GenericFilterSelectorProps> {
const fieldDefinition = getFieldDefinitionForDataset(
globalFilter.tag,
globalFilter.dataset
);
switch (fieldDefinition?.valueType) {
case FieldValueType.NUMBER:
case FieldValueType.DURATION:
return NumericFilterSelector;
case FieldValueType.STRING:
default:
return FilterSelector;
}
}

export function GenericFilterSelector({
globalFilter,
...props
}: GenericFilterSelectorProps) {
const FilterSelectorForType = getFilterSelector(globalFilter);
return <FilterSelectorForType globalFilter={globalFilter} {...props} />;
const fieldDefinition = getFieldDefinitionForDataset(
globalFilter.tag,
globalFilter.dataset
);
const isNumericType =
fieldDefinition?.valueType === FieldValueType.NUMBER ||
fieldDefinition?.valueType === FieldValueType.DURATION;
const Component = isNumericType ? NumericFilterSelector : FilterSelector;
return <Component globalFilter={globalFilter} {...props} />;
}
Loading