fix(performance): Resolve static-component-definitions in performanceWidget#120030
Open
sentry[bot] wants to merge 1 commit into
Open
fix(performance): Resolve static-component-definitions in performanceWidget#120030sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
static-component-definitionsviolation flagged by the React Compiler instatic/app/views/performance/landing/widgets/components/performanceWidget.tsxat line 127.Problem:
The
Containercomponent, used within theDataDisplayfunctional component, was being determined by callinggetPerformanceWidgetContainer({containerType})during render. AlthoughgetPerformanceWidgetContainerreturns one of two pre-defined static styled components (StyledPanelorDiv), the act of calling a function to determine the component type within the render body makes it appear as a dynamically created component to the React Compiler. This violates theStaticComponentsrule, which can lead to unnecessary component unmounting/remounting, state resets, and blocks compiler optimizations.Solution:
To resolve this, the
getPerformanceWidgetContainerfactory function inperformanceWidgetContainer.tsxhas been replaced with a module-scoped static map namedPERFORMANCE_WIDGET_CONTAINERS. This map directly associates eachPerformanceWidgetContainerTypesvalue with its corresponding static styled component.In
performanceWidget.tsx, theDataDisplaycomponent now directly accessesPERFORMANCE_WIDGET_CONTAINERS[containerType]to retrieve theContainercomponent. This ensures that theContainerreference is always a stable, statically defined component, satisfying the React Compiler'sStaticComponentsdiagnostic without altering the intended runtime behavior.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-35A
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.