fix(coding-conventions): Move OverrideOrDefault component definition to module scope in AccountClose#120027
Merged
Merged
Conversation
…to module scope in AccountClose
github-actions
Bot
added
the
Scope: Frontend
TkDodo
approved these changes
Jul 20, 2026
TkDodo
added
the
Trigger: getsentry tests
TkDodo
enabled auto-merge (squash)
July 20, 2026 09:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
static-component-definitionscoding convention violation instatic/app/views/settings/account/accountClose.tsx.The
HookedCustomConfirmAccountClosecomponent was being defined inside theAccountClosefunctional component's render scope usingOverrideOrDefault. This caused a new component type to be created on every render, leading to unstable component identity, state resets, and preventing React Compiler optimizations.To fix this, the
OverrideOrDefaultcall that definesHookedCustomConfirmAccountClosehas been moved to module scope. This ensures the component type is created only once when the module loads, providing a stable reference across all renders ofAccountClose.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-35C
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.