fix(dynamic-sampling): Only query transaction volumes for projects that need balancing#120026
Merged
Merged
Conversation
run_transaction_balancing skips projects at a 100% sample rate, but their transaction volumes were still queried. Return a new ALL_PROJECTS_AT_FULL_SAMPLE_RATE status without querying when every project is at 100%, and otherwise narrow the root-project filter to the projects that will actually be balanced. The query scope stays org-wide because spans rooted in a balanced project can be owned by any project in the org.
github-actions
Bot
added
the
Scope: Backend
shellmayr
marked this pull request as ready for review
July 19, 2026 15:22
vgrozdanic
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_transaction_balancingcurrently skips projects at a 100% sample rate since fix(dynamic-sampling): Skip 100% rate projects in tx balancing #119907, but their transaction volumes were still queried - which is what we wanted to prevent. This PR makes sure we only query transaction volumes when necessaryContributes to TET-2721