fix(seer): Handle InvalidSearchQuery for transaction names#118109
Open
sentry[bot] wants to merge 1 commit into
Open
fix(seer): Handle InvalidSearchQuery for transaction names#118109sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an
InvalidSearchQueryexception that occurred insentry/seer/agent/index_data.pywithin theget_trace_for_transactionfunction.Problem:
The
get_trace_for_transactionfunction constructs a SnQL query using thetransaction_nameparameter. Iftransaction_namecontained literal backslashes (e.g.,http://*/....\\....\\windows\\win.ini), theSpans.run_table_queryparser would interpret these as invalid escape sequences, leading to anInvalidSearchQueryexception and a 500 error for internal RPC calls.Solution:
To prevent these crashes, the call to
Spans.run_table_queryinget_trace_for_transactionis now wrapped in atry...except InvalidSearchQueryblock. If the query parser raises this exception, it is caught, logged, and the function gracefully returnsNone. This ensures that the system handles malformedtransaction_nameinputs without crashing, allowing for a more robust user experience.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5PCT