feat(dashboards): Enable heat map cross-navigation#118108
Open
gggritso wants to merge 1 commit into
Open
Conversation
Wire up opening a dashboard heat map widget in Explore (getWidgetMetricsUrl maps DisplayType.HEATMAP -> ChartType.HEATMAP) and adding an Explore heat map to a dashboard (useAddToDashboard maps ChartType.HEATMAP -> DisplayType.HEATMAP; useSaveAsMetricItems drops the heat-map guards). Adds the DisplayType.HEATMAP enum value as a prerequisite. Dormant behind the data-browsing-heat-map-widget flag. Split out of the heat map dashboard widget work so it can merge independently. Refs DAIN-1654 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables heat map cross-navigation in both directions:
getWidgetMetricsUrlnow mapsDisplayType.HEATMAP->ChartType.HEATMAP.useAddToDashboardmapsChartType.HEATMAP->DisplayType.HEATMAP, anduseSaveAsMetricItemsdrops its heat-map guards.As a prerequisite, this adds the
DisplayType.HEATMAPenum value instatic/app/views/dashboards/types.tsx(a small, additive change the cross-nav code references).This behavior is dormant behind the existing
data-browsing-heat-map-widgetflag — Explore heat maps only exist with that flag, so landing this early is safe. It's split out of the larger heat map dashboard widget work so it can merge independently.Refs DAIN-1654