ref(webhooks): remove legacy sentry_webhooks plugin

.github/codeowners-coverage-baseline.txt

@@ -2196,8 +2196,6 @@ tests/sentry/plugins/interfaces/__init__.py
 tests/sentry/plugins/interfaces/test_releasehook.py
 tests/sentry/plugins/sentry_useragents/__init__.py
 tests/sentry/plugins/sentry_useragents/test_models.py
-tests/sentry/plugins/sentry_webhooks/__init__.py
-tests/sentry/plugins/sentry_webhooks/test_plugin.py
 tests/sentry/plugins/test_config.py
 tests/sentry/plugins/test_helpers.py
 tests/sentry/plugins/test_integration_repository.py

pyproject.toml

@@ -1225,7 +1225,6 @@ module = [
     "sentry.plugins.sentry_interface_types.*",
     "sentry.plugins.sentry_urls.*",
     "sentry.plugins.sentry_useragents.*",
-    "sentry.plugins.sentry_webhooks.*",
     "sentry.plugins.utils",
     "sentry.processing.*",
     "sentry.processing_errors.*",

src/sentry/conf/server.py

@@ -488,7 +488,6 @@ def env(
     "sentry.plugins.sentry_interface_types.apps.Config",
     "sentry.plugins.sentry_urls.apps.Config",
     "sentry.plugins.sentry_useragents.apps.Config",
-    "sentry.plugins.sentry_webhooks.apps.Config",
     "social_auth",
     "sudo",
     "sentry.eventstream",

src/sentry/plugins/__init__.py

@@ -6,7 +6,6 @@
     "jira",
     "pagerduty",
     "opsgenie",
-    "webhooks",
     "amazon-sqs",
     "asana",
     "trello",

src/sentry/rules/actions/notify_event.py

@@ -1,6 +1,5 @@
 from collections.abc import Generator, Sequence
 
-from sentry import features
 from sentry.plugins.base import plugins
 from sentry.rules.actions.base import EventAction
 from sentry.rules.actions.services import LegacyPluginService
@@ -20,16 +19,10 @@ class NotifyEventAction(EventAction):
     def get_plugins(self) -> Sequence[LegacyPluginService]:
         from sentry.plugins.bases.notify import NotificationPlugin
 
-        skip_webhooks = features.has(
-            "organizations:legacy-webhook-disable-old-path", self.project.organization
-        )
-
         results = []
         for plugin in plugins.for_project(self.project, version=1):
             if not isinstance(plugin, NotificationPlugin):
                 continue
-            if skip_webhooks and plugin.slug == "webhooks":
-                continue
             results.append(LegacyPluginService(plugin))
 
         return results

src/sentry/workflow_engine/processors/action.py

@@ -14,6 +14,7 @@
 from sentry.integrations.services.integration import RpcIntegration, integration_service
 from sentry.integrations.types import IntegrationProviderSlug
 from sentry.models.group import Group
+from sentry.models.options.project_option import ProjectOption
 from sentry.models.organization import Organization
 from sentry.models.project import Project
 from sentry.plugins.base import plugins
@@ -344,6 +345,13 @@
     )
 
 
+class _LegacyWebhookStub:
+    slug = "webhooks"
+
+    def get_title(self) -> str:
+        return "WebHooks"
+
+
 def get_notification_plugins_for_org(organization: Organization) -> list[PluginService]:
     """
     Get all plugins for an organization.
@@ -362,6 +370,15 @@
 
             plugin_map[plugin.slug] = PluginService(plugin)
 
+    if "webhooks" not in plugin_map:
+        has_webhooks = ProjectOption.objects.filter(
+            project__organization_id=organization.id,
+            key="webhooks:enabled",
+            value=True,
+        ).exists()
+        if has_webhooks:
+            plugin_map["webhooks"] = PluginService(_LegacyWebhookStub())
+
     return list(plugin_map.values())