Skip to content

fix(seer): show GitLab icon for GitLab SCM links in evidence UI #118055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billyvg merged 4 commits into from
Jun 22, 2026
+13 −5
Merged

fix(seer): show GitLab icon for GitLab SCM links in evidence UI #118055

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c52b0f7
fix(seer): show GitLab icon for GitLab SCM links in Seer evidence UI
billyvg Jun 18, 2026
2123f6b
fix(seer): use provider param for SCM icon in git_search evidence
billyvg Jun 18, 2026
cccd003
style(seer): Apply formatter to autofixEvidence destructuring
billyvg Jun 19, 2026
3ec7cc5
reusabnle component
billyvg Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions static/app/components/events/autofix/v3/autofixEvidence.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {LinkButton} from '@sentry/scraps/button';
import {IconCompass} from 'sentry/icons/iconCompass';
import {IconFile} from 'sentry/icons/iconFile';
import {IconGithub} from 'sentry/icons/iconGithub';
import {IconGitlab} from 'sentry/icons/iconGitlab';
import {IconIssues} from 'sentry/icons/iconIssues';
import {IconPlay} from 'sentry/icons/iconPlay';
import {IconProfiling} from 'sentry/icons/iconProfiling';
Expand Down Expand Up @@ -309,16 +310,23 @@ function getCodeSearchEvidenceProps({
return null;
}

function getScmIcon(provider: string | undefined): ReactNode {
if (provider === 'integrations:gitlab') {
return <IconGitlab />;
}
return <IconGithub />;

@billyvg billyvg Jun 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for old explorer runs we won;t have provider so im keeping github as the default

@ryan953 ryan953 Jun 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RepoProviderIcon might be a good import for here

@billyvg billyvg Jun 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect thanks

}

function getGitSearchEvidenceProps({
toolLink,
}: GetEvidencePropsPayload): EvidenceButtonProps | null {
const {repo_name, commit_url, sha, commits_url, start_date, end_date, file_path} =
const {repo_name, commit_url, sha, commits_url, start_date, end_date, file_path, provider} =
toolLink?.params ?? {};

if (typeof commit_url === 'string' && typeof sha === 'string') {
return {
href: commit_url,
icon: <IconGithub />, // TODO: support other SCMs
icon: getScmIcon(provider),
label: t('Commit: %s', truncateText(getShortCommitHash(sha))),
tooltip: sha,
};
Expand All @@ -334,7 +342,7 @@ function getGitSearchEvidenceProps({
typeof file_path === 'string' ? extractFileName(file_path) : undefined;
return {
href: commits_url,
icon: <IconGithub />, // TODO: support other SCMs
icon: getScmIcon(provider),
label: t('Commits: %s', fileName ? truncateText(fileName) : repo_name),
tooltip: (
<Fragment>
Comment thread
sentry[bot] marked this conversation as resolved.
Expand Down
Loading