Skip to content

fix(logs): extract collapse functionality into its own button #118053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianviquez merged 2 commits into from
Jun 18, 2026
+10 −23
Merged

fix(logs): extract collapse functionality into its own button #118053

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e37c29e
fix(logs): extract collapse functionality into its own button
adrianviquez Jun 18, 2026
60922c8
adjust aria-lable consistencies
adrianviquez Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 10 additions & 23 deletions static/app/views/explore/logs/logsGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {OverlayTrigger} from '@sentry/scraps/overlayTrigger';
import Feature from 'sentry/components/acl/feature';
import {DropdownMenu, type MenuItemProps} from 'sentry/components/dropdownMenu';
import {usePageFilters} from 'sentry/components/pageFilters/usePageFilters';
import {IconClock, IconEllipsis, IconExpand, IconGraph} from 'sentry/icons';
import {IconClock, IconContract, IconEllipsis, IconExpand, IconGraph} from 'sentry/icons';
import {t} from 'sentry/locale';
import type {NewQuery} from 'sentry/types/organization';
import {trackAnalytics} from 'sentry/utils/analytics';
Expand Down Expand Up @@ -234,18 +234,20 @@ function Graph({
menuTitle="Interval"
options={intervalOptions}
/>
<ContextMenu
interval={interval}
visualize={visualize}
setVisible={onChartVisibilityChange}
<ContextMenu interval={interval} visualize={visualize} />
<Button
aria-label={t('Collapse chart')}
icon={<IconContract />}
onClick={() => onChartVisibilityChange(false)}
size="xs"
/>
</Fragment>
) : (
<Button
aria-label="Expand"
aria-label={t('Expand')}

@JoshuaKGoldberg JoshuaKGoldberg Jun 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Bug] I just noticed that it says "expand" vs "collapse chart". So, totally optional if you're interested:

Suggested change
aria-label={t('Expand')}
aria-label={t('Expand chart')}

icon={<IconExpand />}
onClick={() => onChartVisibilityChange(true)}
size="sm"
size="xs"
/>
);

Expand Down Expand Up @@ -276,15 +278,7 @@ function Graph({
);
}

function ContextMenu({
interval,
visualize,
setVisible,
}: {
interval: string;
setVisible: (visible: boolean) => void;
visualize: Visualize;
}) {
function ContextMenu({interval, visualize}: {interval: string; visualize: Visualize}) {
const location = useLocation();
const organization = useOrganization();
const {projects} = useProjects();
Expand All @@ -304,12 +298,6 @@ function ContextMenu({
const disableAddToDashboard = !organization.features.includes('dashboards-edit');

return [
{
key: 'hide-chart',
textValue: t('Collapse Chart'),
label: t('Collapse Chart'),
onAction: () => setVisible(false),
},
{
key: 'create-alert',
textValue: t('Create an Alert'),
Expand Down Expand Up @@ -408,7 +396,6 @@ function ContextMenu({
pageFilters,
projects,
search,
setVisible,
visualize.chartType,
visualize.yAxis,
]);
Expand Down
Loading