ref(plugins): remove dead tag derivation plugins#118046
Draft
Christinarlong wants to merge 2 commits into
Draft
Conversation
The `sentry_urls`, `sentry_interface_types`, and `sentry_useragents` plugins have been fully replaced by the `TagDeriver` protocol in `event_manager_auto_tags.py`. Remove the plugin directories, the `TagPlugin` base class, INSTALLED_APPS entries, mypy exclusions, tests, and codeowners references.
github-actions
Bot
added
the
Scope: Backend
…entity Move `sentry.integrations.*` imports in `sentry/identity/pipeline.py` from module-level to inside the methods that use them. This breaks a latent circular import cycle: sentry.integrations.base → sentry.identity (eagerly registers providers) → sentry.identity.pipeline → sentry.integrations.base The cycle was previously masked by the tag-derivation plugins' position in INSTALLED_APPS, which caused sentry.identity to be fully loaded before the cycle could trigger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sentry_urls,sentry_interface_types, andsentry_useragentstag plugins — they've been fully replaced by theTagDeriverprotocol inevent_manager_auto_tags.pyTagPluginbase class,INSTALLED_APPSentries, mypy exclusions, tests, and codeowners referencesTest plan
prek run -qpasses on changed filespytest tests/sentry/event_manager/test_auto_tags.pyconfirms the new tag derivation still works