build(ui): Enable react compiler annotation, rspack 2.1#118033
Draft
scttcper wants to merge 1 commit into
Draft
Conversation
i tried `reactCompiler: true` and it panics in rust. but this option works https://react.dev/reference/react-compiler/configuration#compilation-control
github-actions
Bot
added
the
Scope: Frontend
scttcper
changed the title
annotationannotation, rspack 2.1
scttcper
changed the title
annotation, rspack 2.1annotation, rspack 2.1
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
2995
to
+2997
| peerDependencies: | ||
| '@module-federation/runtime-tools': ^0.24.1 || ^2.0.0 | ||
| '@swc/helpers': '>=0.5.1' | ||
| '@swc/helpers': ^0.5.23 |
Contributor
There was a problem hiding this comment.
Bug: The lockfile resolves @swc/helpers to 0.5.15, which does not satisfy the ^0.5.23 peer dependency from the newly updated @rspack/core@2.1.0-beta.0, risking runtime errors.
Severity: MEDIUM
Suggested Fix
Ensure the version of @swc/helpers in the lockfile is upgraded to at least 0.5.23 to satisfy the peer dependency requirement of @rspack/core@2.1.0-beta.0. This can be done by running pnpm install or manually updating the lockfile to resolve the correct version.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: pnpm-lock.yaml#L2995-L2997
Potential issue: The update to `@rspack/core@2.1.0-beta.0` introduces a peer dependency
requirement for `@swc/helpers` of version `^0.5.23`. However, the `pnpm-lock.yaml` file
resolves `@swc/helpers` to version `0.5.15`, which violates this semantic versioning
constraint. This mismatch, especially when using a beta version of `rspack`, could lead
to runtime failures because `rspack` may rely on helpers or changes that were introduced
in the newer versions of `@swc/helpers`. While the peer dependency is marked as
optional, the explicit version requirement suggests it's necessary for certain
functionalities to work correctly.
Also affects:
package.json:101~108
Did we get this right? 👍 / 👎 to inform future reviews.
Member
Author
There was a problem hiding this comment.
swc only used w/ jest, its fine but can fix as it gets closer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i tried
reactCompiler: trueand it panics in rust. but this option works https://react.dev/reference/react-compiler/configuration#compilation-control this requires components opt in via'use memo';