Skip to content

fix(issues): return all matched short ids instead of redirecting to one#118032

Merged
cvxluo merged 1 commit into
masterfrom
cvxluo/return-all-matched-short-ids-instead-of-redirectin
Jun 18, 2026
Merged

fix(issues): return all matched short ids instead of redirecting to one#118032
cvxluo merged 1 commit into
masterfrom
cvxluo/return-all-matched-short-ids-instead-of-redirectin

Conversation

@cvxluo

@cvxluo cvxluo commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Scanning each query token for a short id meant a query with multiple short ids (e.g. "SENTRY-1 SENTRY-2") redirected to whichever resolved first. Return every matched group instead, and only set the direct hit header when a single short id matches.

There are some inconsistencies between short ids and event ids redirecting (#116153 is the offending PR), namely that filters + event id(s) do not redirect, while filters + short ids do. I considered making the behaviors consistent here, but it seems like the short id path is happening more often with users, so I'm holding off for now.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 18, 2026
@cvxluo cvxluo force-pushed the cvxluo/return-all-matched-short-ids-instead-of-redirectin branch 2 times, most recently from 309f073 to 393aa73 Compare June 18, 2026 16:55
Scanning each query token for a short id meant a query with multiple short ids (e.g. SENTRY-1 SENTRY-2) redirected to whichever resolved first. Return every matched group instead, and only set the direct-hit header when a single short id matches, mirroring how multiple group ids are handled.

Co-authored-by: Claude <noreply@anthropic.com>
@cvxluo cvxluo force-pushed the cvxluo/return-all-matched-short-ids-instead-of-redirectin branch from 393aa73 to cce7806 Compare June 18, 2026 18:09
@cvxluo cvxluo marked this pull request as ready for review June 18, 2026 18:10
@cvxluo cvxluo requested review from a team as code owners June 18, 2026 18:10
@cvxluo cvxluo merged commit 494d0d2 into master Jun 18, 2026
68 checks passed
@cvxluo cvxluo deleted the cvxluo/return-all-matched-short-ids-instead-of-redirectin branch June 18, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants