Skip to content

fix(ourlogs): nudge truncation constant up a power of 2#118023

Merged
JoshuaKGoldberg merged 1 commit into
masterfrom
logs-query-truncate-from-16-to-12
Jun 22, 2026
Merged

fix(ourlogs): nudge truncation constant up a power of 2#118023
JoshuaKGoldberg merged 1 commit into
masterfrom
logs-query-truncate-from-16-to-12

Conversation

@JoshuaKGoldberg

Copy link
Copy Markdown
Member

I noticed the ... truncation happening on my wide monitor view for logs whose messages have a long first line. This bumps up their target string lengths by a power of two so that shouldn't happen anymore. The actual font width is closer to 12 than 16 anyway.

Before After
image image

Closes LOGS-884.

@linear-code

linear-code Bot commented Jun 18, 2026

Copy link
Copy Markdown

LOGS-884

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 18, 2026
@JoshuaKGoldberg

Copy link
Copy Markdown
Member Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 4fafe43. Configure here.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from k-fish June 18, 2026 15:19
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review June 18, 2026 15:19
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team as a code owner June 18, 2026 15:19
@JoshuaKGoldberg JoshuaKGoldberg merged commit 0d9ff4f into master Jun 22, 2026
72 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the logs-query-truncate-from-16-to-12 branch June 22, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants