fix(search): render escaped asterisks as escaped#118019
Merged
JoshuaKGoldberg merged 2 commits intoJun 18, 2026
Merged
Conversation
When a filter token value contains an escaped asterisk (\*), formatFilterValue previously stripped the escape via unescapeAsteriskSearchValue before display, so a literal \* rendered identically to an active wildcard *. Stop stripping the escape in the VALUE_TEXT branch so escaped asterisks render as escaped, letting users distinguish a literal star from a wildcard. This is in the shared SearchQueryBuilder component, so it applies everywhere the component (and FormattedQuery) is used. Fixes LOGS-880
github-actions
Bot
added
the
Scope: Frontend
JoshuaKGoldberg
changed the title
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 188563b. Configure here.
nsdeschenes
approved these changes
Jun 18, 2026
JoshuaKGoldberg
deleted the
joshgoldberg/logs-880-bug-render-escaped-asterisks-as-escaped
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the shared
SearchQueryBuilder, filter token values containing an escaped asterisk (\*) were rendered identically to an active wildcard (*). Eek. This PR adds a visual\to differentiate.Given the
messagecontains query witha * b \* c:Closes LOGS-880.