ref: cleanup page-frame feature flag#117974
Draft
TkDodo wants to merge 37 commits into
Draft
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-jhpa8s5ey.sentry.dev |
TkDodo
commented
Jun 18, 2026
| return ( | ||
| <ResourcesWrapper data-test-id="resources"> | ||
| <Layout.Title withMargins>{t('Resources')}</Layout.Title> | ||
| <Layout.Title>{t('Resources')}</Layout.Title> |
Collaborator
Author
There was a problem hiding this comment.
note: withMargin didn’t do anything for page-frame mode. Layout.Title is now just a TopBar.Slot and should likely be inlined in a follow-up
Collaborator
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sine Layout.Title always renders a slot, and we have no slot there, this would nuke the title
Collaborator
Author
|
bugbot run |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 593c466. Configure here.
we now have a global h1 in the test helpers
The page-frame command palette eagerly fetches starred Explore saved queries on every route. Without this feature the endpoint 404s and TanStack Query retries it (4 requests), adding load/latency that can tip the page past the Selenium waits. Enabling it returns a 200 (empty list) and avoids the retries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on: