fix(middleware): guard request.auth access in is_frontend_request#117966
Merged
Conversation
markstory
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an
AttributeError: 'WSGIRequest' object has no attribute 'auth'occurring insrc/sentry/middleware/__init__.pywithin theis_frontend_requestfunction.Root Cause:
The
is_frontend_requestfunction was directly accessingrequest.auth. While type-hinted for a DRFRequest(which has an.authattribute), it was being called by middleware likeaccess_log_middlewarewith plain DjangoWSGIRequestobjects. TheseWSGIRequestobjects do not possess an.authattribute, leading to anAttributeErrorfor requests that are short-circuited (e.g., redirects, internal RPC calls) before DRF authentication can populate the attribute.Solution:
request.authaccess: Changedrequest.auth is Nonetogetattr(request, "auth", None) is Noneinis_frontend_request. This defensive access prevents theAttributeErrorby safely checking for the attribute's existence. This aligns with the pattern already used by_get_request_authinaccess_log.py.requestparameter inis_frontend_requestfromRequesttoHttpRequest | Request. This accurately reflects that the function can receive both Django's baseHttpRequestand DRF'sRequestobjects, improving type safety and clarity.This fix eliminates a significant source of handled
AttributeErrorlogs (over 31k events) without altering the intended statistical behavior ofis_frontend_request.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-3VXH