Skip to content

ref(issues): Rename progress state 'triaged' to 'assigned' #117964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malwilley merged 5 commits into from
Jun 22, 2026
Merged

ref(issues): Rename progress state 'triaged' to 'assigned' #117964

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5e9795
ref(issues): Rename progress state 'triaged' to 'assigned'
malwilley Jun 17, 2026
f18343e
ref(issues): Add IconTriaged for assigned progress state
malwilley Jun 17, 2026
d1f8256
Rename icons to be progress-agnostic
malwilley Jun 18, 2026
83a13da
Rename IconResolved to IconCircleCheckmark
malwilley Jun 18, 2026
2a40b6c
Merge remote-tracking branch 'origin/master' into malwilley/rename-tr…
malwilley Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions static/app/icons/iconTriaged.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import type {SVGIconProps} from './svgIcon';
import {SvgIcon} from './svgIcon';

export function IconTriaged(props: SVGIconProps) {
return (
<SvgIcon {...props}>
<path d="M8 3C10.76 3 13 5.24 13 8H8V3Z" />
<path
fillRule="evenodd"
clipRule="evenodd"
d="M8 0C12.42 0 16 3.58 16 8C16 12.42 12.42 16 8 16C3.58 16 0 12.42 0 8C0 3.58 3.58 0 8 0ZM8 1.5C4.41 1.5 1.5 4.41 1.5 8C1.5 11.59 4.41 14.5 8 14.5C11.59 14.5 14.5 11.59 14.5 8C14.5 4.41 11.59 1.5 8 1.5Z"
/>
</SvgIcon>
);
}
7 changes: 7 additions & 0 deletions static/app/icons/icons.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,13 @@ const SECTIONS: TSection[] = [
name: 'InReview',
defaultProps: {},
},
{
id: 'triaged',
groups: ['status'],
keywords: ['circle', 'progress', 'assigned'],
name: 'Triaged',

@saponifi3d saponifi3d Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make these assigned as well? 🤔 or maybe something around a progress circle or something to decouple it from the state name?

@malwilley malwilley Jun 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes probably better to do this!

Renamed to reference their appearance:

CleanShot 2026-06-18 at 09 28 06

defaultProps: {},
},
{
id: 'resolved',
groups: ['status'],
Expand Down
1 change: 1 addition & 0 deletions static/app/icons/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ export {IconTerminal} from './iconTerminal';
export {IconThumb} from './iconThumb';
export {IconTimer} from './iconTimer';
export {IconTrello} from './iconTrello';
export {IconTriaged} from './iconTriaged';

@saponifi3d saponifi3d Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the icon name to IconAssigned as well?

@malwilley malwilley Jun 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned in the PR description that I didn't like IconAssigned because it might be confused with the user icon. But I do agree that these icons probably would be better if we named them something completely different (based on their appearance rather than their relation to progress)

export {IconUnsubscribed} from './iconUnsubscribed';
export {IconUpgrade} from './iconUpgrade';
export {IconUpload} from './iconUpload';
Expand Down
7 changes: 4 additions & 3 deletions static/app/views/issueList/utils/progress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,20 @@ import {IconCircle} from 'sentry/icons/iconCircle';
import {IconInProgress} from 'sentry/icons/iconInProgress';
import {IconInReview} from 'sentry/icons/iconInReview';
import {IconResolved} from 'sentry/icons/iconResolved';
import {IconTriaged} from 'sentry/icons/iconTriaged';
import {t} from 'sentry/locale';

export enum ProgressState {
IDENTIFIED = 'identified',
TRIAGED = 'triaged',
ASSIGNED = 'assigned',
DIAGNOSED = 'diagnosed',
FIX_PROPOSED = 'fix_proposed',
FIX_APPLIED = 'fix_applied',
}

const PROGRESS_STATE_LABELS: Record<ProgressState, string> = {
[ProgressState.IDENTIFIED]: t('Identified'),
[ProgressState.TRIAGED]: t('Triaged'),
[ProgressState.ASSIGNED]: t('Assigned'),
[ProgressState.DIAGNOSED]: t('Diagnosed'),
[ProgressState.FIX_PROPOSED]: t('Fix Proposed'),
[ProgressState.FIX_APPLIED]: t('Fix Applied'),
Expand All @@ -31,7 +32,7 @@ export function formatProgressState(state: ProgressState | null): string {

const PROGRESS_STATE_ICONS: Record<ProgressState, ReactNode> = {
[ProgressState.IDENTIFIED]: <IconCircle size="md" variant="muted" />,
[ProgressState.TRIAGED]: <IconCircle size="md" variant="muted" />,
[ProgressState.ASSIGNED]: <IconTriaged size="md" variant="muted" />,
[ProgressState.DIAGNOSED]: <IconInProgress size="md" variant="warning" />,
[ProgressState.FIX_PROPOSED]: <IconInReview size="md" variant="success" />,
[ProgressState.FIX_APPLIED]: <IconResolved size="md" variant="success" />,
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueList/utils/useFetchIssueTags.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ function builtInIssuesFields({
[FieldKey.ISSUE_PROGRESS]: {
...PREDEFINED_FIELDS[FieldKey.ISSUE_PROGRESS]!,
name: 'Issue Progress',
values: ['identified', 'triaged', 'diagnosed', 'fix_proposed', 'fix_applied'],
values: ['identified', 'assigned', 'diagnosed', 'fix_proposed', 'fix_applied'],
Comment thread
malwilley marked this conversation as resolved.
predefined: true,
},
[FieldKey.ISSUE_SEER_ACTIONABILITY]: {
Expand Down
Loading