Skip to content

fix(ACI): Error when updating non-Anomaly Detection to Anomaly Detection#117947

Merged
saponifi3d merged 2 commits into
masterfrom
jcallender/fix-ad-updates
Jun 18, 2026
Merged

fix(ACI): Error when updating non-Anomaly Detection to Anomaly Detection#117947
saponifi3d merged 2 commits into
masterfrom
jcallender/fix-ad-updates

Conversation

@saponifi3d

Copy link
Copy Markdown
Contributor

Description

QUICK FIX: This is a quick fix to address a problem where anomaly validation requires there to only be one data condition, however the data conditions that are being looked up are from before the update.

This change will create in in memory DataCondition if we are going to update an anomaly detection, and pass that along so everything can update in the correct order.


As a future follow up, we should probably revisit the logic here an wether updates are happening in the correct order.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2026
Comment thread src/sentry/incidents/metric_issue_detector.py
@saponifi3d saponifi3d marked this pull request as ready for review June 17, 2026 22:39
@saponifi3d saponifi3d requested review from a team as code owners June 17, 2026 22:39
Comment thread src/sentry/incidents/metric_issue_detector.py
@saponifi3d saponifi3d requested a review from a team June 17, 2026 23:26
@saponifi3d saponifi3d merged commit f5481d0 into master Jun 18, 2026
63 checks passed
@saponifi3d saponifi3d deleted the jcallender/fix-ad-updates branch June 18, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants