feat(nav): open starred issue views in a new tab on modifier-click

[cvxluo]

Support ctrl/cmd click to open a starred view in a new tab.

[cvxluo]

there was a consistent bug where dragging a starred view to a new location, then back, caused a reload. i tried a number of approaches here to prevent it and this was the only one that worked, but i couldn't figure out a way to make this less hacky

[scttcper]

Codex AI comment:

I think we can avoid the global click suppression by changing the structure slightly.

The hack exists because the drag handle is nested inside a real <Link>. After dnd-kit activates a drag, it stops propagation of the synthesized click, but it does not call preventDefault(), so the anchor default navigation can still happen. That forces us to install a native document capture listener after onDragEnd just to cancel the next click.

Instead, we could render the link and drag handle as siblings inside the sortable <li>:

• keep the main nav item as a real <Link> so cmd/ctrl/middle-click works naturally
• render the dnd-kit activator handle outside the link
• absolutely position the handle over the icon slot on hover/focus
• keep setNodeRef on the sortable list item, and setActivatorNodeRef/listeners on the handle

Rough shape:

<Container as="li" ref={setNodeRef} ...>
  <StyledReorderableLink to={to} ...>
    <IconSlot>{icon}</IconSlot>
    {children}
    {trailingItems}
  </StyledReorderableLink>
  <GrabHandle />
</Container>

That way a drag starts from a non-anchor element, so there is no anchor default navigation to suppress after pointerup. The global suppressNextClick() helper can go away, and the link remains a normal browser link for modifier clicks.

The tradeoff is a little more positioning/CSS around the handle and icon slot, but the event model becomes much cleaner: links navigate, handles drag.

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit f9f9f8f. Configure here.}

[cursor]

Handle wrapper blocks icon clicks

Medium Severity

Moving GrabHandle outside the anchor leaves an absolutely positioned Flex over the project icon. Only the inner GrabHandleAnimation uses pointer-events: none; the wrapper still receives clicks, so taps on the icon no longer reach the Link and the starred view does not open.

 

^{Reviewed by Cursor Bugbot for commit f9f9f8f. Configure here.}

[cursor]

Handle offset without positioning

Low Severity

GrabHandleAnimation sets left: calc(...) and transform: translate(-50%, -50%) to center over the project icon, but the styled div is not positioned (position: absolute with a vertical anchor). The left offset is ignored, so the drag activator may not sit on the icon the comment describes.

 

^{Reviewed by Cursor Bugbot for commit f9f9f8f. Configure here.}

[scttcper]

feels pretty good