Skip to content

style(weekly-report): Update colors#117877

Merged
amy-chen23 merged 6 commits into
masterfrom
amyc/weekly-report-update-colors
Jun 17, 2026
Merged

style(weekly-report): Update colors#117877
amy-chen23 merged 6 commits into
masterfrom
amyc/weekly-report-update-colors

Conversation

@amy-chen23

@amy-chen23 amy-chen23 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Goal: update weekly report styling

Changes

  • Followed color and font guidelines from sentry
  • Show the Issue Title and Issue Message (similar to how issues are shown on the Issue Feed) -- originally, we only showed Issue Message which was confusing because it was often truncated
  • Added "Issue with the most errors" and "Most frequent performance issues" to the dev env

To test:

  • Start dev environment
  • Go to debug/mail/weekly-reports/?seed=90

Before:
image

After:
image

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 16, 2026
@amy-chen23 amy-chen23 force-pushed the amyc/weekly-report-update-colors branch from 59db218 to 3332f68 Compare June 16, 2026 22:23
@amy-chen23 amy-chen23 marked this pull request as ready for review June 17, 2026 21:33
@amy-chen23 amy-chen23 requested review from a team as code owners June 17, 2026 21:33
@amy-chen23 amy-chen23 requested a review from a team June 17, 2026 21:33
unique_enum_count = len(enum_values)
assert len(group_status_to_color) == unique_enum_count

def test_key_errors_and_performance_issues_share_substatus_badges(self) -> None:

@amy-chen23 amy-chen23 Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarification on why the test exists: We want the "ongoing" label color to be consistent for both key errors and performance issues. It used to be gray for key errors and yellow for performance issues.

</style>

<style type="text/css" inline="false">
@import url(https://fonts.googleapis.com/css2?family=Rubik:wght@400;500;700&display=swap);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we typically avoid using google fonts

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not really even worth doing usually https://www.caniemail.com/features/css-at-font-face/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the heads up, i won't make changes to the font then 👍

@amy-chen23 amy-chen23 changed the title style(weekly-report): Update colors and fonts style(weekly-report): Update colors Jun 17, 2026
@amy-chen23 amy-chen23 merged commit edfe2ed into master Jun 17, 2026
65 checks passed
@amy-chen23 amy-chen23 deleted the amyc/weekly-report-update-colors branch June 17, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants