ref(dashboards): Extract shared heat map chart utilities#117873
Merged
Conversation
Move Explore's heat map helpers into a shared heatMapWidget location so the upcoming dashboards heat map widget can reuse them: the X/Y bucket-sizing helpers (getHeatmapXAxisBucketInterval, getHeatmapYAxisBucketCount), the metric-unit patch (mergeMetricUnit), and heat map settings (PIXELS_PER_BUCKET, HEATMAP_Z_AXIS_SCALE). The Explore metric panel and heat map now import them. Behavior-preserving refactor split from the larger heat map dashboard widget work. Refs DAIN-1654 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5b180cc. Configure here.
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
Move Explore's existing heat map helpers verbatim instead of rewriting them. The previous version of this branch simplified the helpers while relocating them, which silently changed Explore's behavior (it dropped the 1d interval option for long ranges and replaced the width-gated Y-bucket math). Restore the original getHeatmapXBucketInterval / getHeatmapYBuckets bodies and signatures (and PIXELS_PER_X_BUCKET = 15) under the renamed shared files so this is a true no-op refactor for Explore. Refs DAIN-1654
…at-map-utils' into georgegritsouk/extract-shared-heat-map-utils ; Conflicts: ; static/app/views/dashboards/widgets/heatMapWidget/settings.ts
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
billyvg
pushed a commit
that referenced
this pull request
Jun 17, 2026
In an attempt to make a future PR less insane, this PR takes some of the current Heat Map behaviour and splits out the helpers into their own files and so on. Refs DAIN-1654 --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
|
nice |
sehr-m
pushed a commit
that referenced
this pull request
Jun 23, 2026
In an attempt to make a future PR less insane, this PR takes some of the current Heat Map behaviour and splits out the helpers into their own files and so on. Refs DAIN-1654 --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an attempt to make a future PR less insane, this PR takes some of the current Heat Map behaviour and splits out the helpers into their own files and so on.
Refs DAIN-1654