feat(preprod): Use one relevant-filtered link per snapshot row#117863
Merged
Conversation
The snapshot status check and PR comment rendered a separate link on every count column, so a single row could carry up to six links and reviewers could not tell which to click. Each row now exposes one link in the Name column, pointing at the diff view filtered to only the categories that actually changed (added/removed/changed/renamed); count columns become plain numbers. When nothing relevant changed, the link opens unfiltered so unchanged/skipped views are not hidden behind a stale filter. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
Compute the comparison lookup and selected-types decision once before rendering each snapshot table row. This keeps the filtered link behavior unchanged while avoiding a second name cell build for completed rows. Co-Authored-By: OpenAI Codex <noreply@openai.com>
NicoHinderling
approved these changes
Jun 16, 2026
billyvg
pushed a commit
that referenced
this pull request
Jun 17, 2026
The snapshot status check and PR comment previously put a separate link on every count column (Added/Removed/Changed/Renamed/Unchanged/Skipped), so a single row could carry up to six links and reviewers couldn't tell which one to click. Each row now exposes a single link in the Name column that opens the snapshot diff view filtered to only the categories that actually changed, with the count columns rendered as plain numbers. The link's `?selectedTypes=` filter is built from the non-zero relevant categories (`added`, `removed`, `changed`, `renamed`) — `unchanged`, `skipped`, and `errored` are never included. When nothing relevant changed, the link opens unfiltered so a reviewer is never shown an empty filtered view. The change is confined to the shared markdown templates in `src/sentry/preprod/vcs/`; the `selectedTypes` URL param and its comma-separated parsing already exist on the frontend, so no UI change is needed. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: OpenAI Codex <noreply@openai.com>
sehr-m
pushed a commit
that referenced
this pull request
Jun 23, 2026
The snapshot status check and PR comment previously put a separate link on every count column (Added/Removed/Changed/Renamed/Unchanged/Skipped), so a single row could carry up to six links and reviewers couldn't tell which one to click. Each row now exposes a single link in the Name column that opens the snapshot diff view filtered to only the categories that actually changed, with the count columns rendered as plain numbers. The link's `?selectedTypes=` filter is built from the non-zero relevant categories (`added`, `removed`, `changed`, `renamed`) — `unchanged`, `skipped`, and `errored` are never included. When nothing relevant changed, the link opens unfiltered so a reviewer is never shown an empty filtered view. The change is confined to the shared markdown templates in `src/sentry/preprod/vcs/`; the `selectedTypes` URL param and its comma-separated parsing already exist on the frontend, so no UI change is needed. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snapshot status check and PR comment previously put a separate link on every count column (Added/Removed/Changed/Renamed/Unchanged/Skipped), so a single row could carry up to six links and reviewers couldn't tell which one to click. Each row now exposes a single link in the Name column that opens the snapshot diff view filtered to only the categories that actually changed, with the count columns rendered as plain numbers.
The link's
?selectedTypes=filter is built from the non-zero relevant categories (added,removed,changed,renamed) —unchanged,skipped, anderroredare never included. When nothing relevant changed, the link opens unfiltered so a reviewer is never shown an empty filtered view.The change is confined to the shared markdown templates in
src/sentry/preprod/vcs/; theselectedTypesURL param and its comma-separated parsing already exist on the frontend, so no UI change is needed.