feat(project-creation): Make alert frequency collapsible via ScmCollapsibleSection#117849
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
This was referenced Jun 16, 2026
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-section
branch
from
7c6a809 to
c20e5e2
Compare
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-alert-frequency
branch
from
acde609 to
7d94fd3
Compare
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-section
branch
from
c20e5e2 to
b56d395
Compare
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-alert-frequency
branch
from
7d94fd3 to
370a8cb
Compare
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-alert-frequency
branch
from
370a8cb to
433a8e8
Compare
Abdkhan14
approved these changes
Jun 18, 2026
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-alert-frequency
branch
from
433a8e8 to
54178a9
Compare
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-section
branch
from
513fc52 to
31441bf
Compare
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-section
branch
from
31441bf to
8c502bd
Compare
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-alert-frequency
branch
from
54178a9 to
ed068d0
Compare
jaydgoss
added a commit
that referenced
this pull request
Jun 22, 2026
…low (#117846) ## TLDR Typography and copy polish across the SCM project-creation flow: normalized heading levels and text sizing, and simplified the create-project intro copy. ## Details - Dropped section headings from `h2`/`xl` to `h3` and stepped body text from `lg` to `md` across `scmFeatureInfoCards`, `scmFeatureSelectionCards`, `scmProjectDetailsCore`, and `scmCreateProject`. - Simplified the create-project intro copy and removed the docs link. ## Stack - [#117731](#117731): SCM integration selector (base of this PR) - **PR 2 (this) #117846:** Typography and copy polish - [#117847](#117847): Reusable collapsible section (stacked on this) - [#117849](#117849): Alert-frequency collapsible Draft: more changes coming on this branch.
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-section
branch
from
8c502bd to
a191798
Compare
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-alert-frequency
branch
from
ed068d0 to
26e25df
Compare
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-section
branch
from
a191798 to
d935cd4
Compare
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-alert-frequency
branch
from
26e25df to
4c80589
Compare
jaydgoss
added a commit
that referenced
this pull request
Jun 22, 2026
…low (#117847) ## TLDR Introduces `ScmCollapsibleSection`, a reusable collapsible section for the SCM project-creation flow. The component lands on its own here and is not yet consumed in production; the alert-frequency follow-up (#117849) is its first consumer. ## Details - `ScmCollapsibleSection` puts the chevron and title in one transparent toggle button (mirroring the core Disclosure look) with an optional trailing slot pinned right. The body animates its own height (auto to 0) so sibling `layout="position"` cards below reflow through normal document flow, and `initial={false}` skips the mount animation so it renders in its `defaultExpanded` state. - It is a local variant of the core Disclosure rather than a consumer: `Disclosure.Content` hides with `display: none`, which cannot tween and would not reflow the sibling cards, and `Disclosure.Title`'s full-width stretched button cannot express a content-hugging toggle without forking the shared component. - The component has no production consumer in this PR, so it is added to the knip production entry points (see `knip.config.ts`). #117849 removes that exemption when it wires the component into alert frequency. ## Stack - [#117731](#117731): SCM integration selector (merged) - [#117846](#117846): Typography and copy polish (merged) - **PR 3 (this) #117847:** Reusable collapsible section - [#117849](#117849): Alert-frequency collapsible (stacked on this)
…psibleSection Apply ScmCollapsibleSection to the alert-frequency section in ScmProjectDetailsCore so it folds away in the project-creation flow (`collapsible = analyticsFlow === 'project-creation'`). Onboarding keeps the section always expanded. When collapsible, the chevron and title sit in the toggle and the "Get notified when things go wrong" subtitle moves into the collapsible body so it hides when collapsed. Onboarding renders the same header (bold label + subtitle) with the alert control always visible.
Alert frequency now consumes ScmCollapsibleSection in production, so the production-entry exemption added alongside the component is redundant and would trip knip's config-hint check. Remove it.
jaydgoss
force-pushed
the
jaygoss/scm-collapsible-alert-frequency
branch
from
4c80589 to
176241c
Compare
sehr-m
pushed a commit
that referenced
this pull request
Jun 23, 2026
…low (#117846) ## TLDR Typography and copy polish across the SCM project-creation flow: normalized heading levels and text sizing, and simplified the create-project intro copy. ## Details - Dropped section headings from `h2`/`xl` to `h3` and stepped body text from `lg` to `md` across `scmFeatureInfoCards`, `scmFeatureSelectionCards`, `scmProjectDetailsCore`, and `scmCreateProject`. - Simplified the create-project intro copy and removed the docs link. ## Stack - [#117731](#117731): SCM integration selector (base of this PR) - **PR 2 (this) #117846:** Typography and copy polish - [#117847](#117847): Reusable collapsible section (stacked on this) - [#117849](#117849): Alert-frequency collapsible Draft: more changes coming on this branch.
sehr-m
pushed a commit
that referenced
this pull request
Jun 23, 2026
…low (#117847) ## TLDR Introduces `ScmCollapsibleSection`, a reusable collapsible section for the SCM project-creation flow. The component lands on its own here and is not yet consumed in production; the alert-frequency follow-up (#117849) is its first consumer. ## Details - `ScmCollapsibleSection` puts the chevron and title in one transparent toggle button (mirroring the core Disclosure look) with an optional trailing slot pinned right. The body animates its own height (auto to 0) so sibling `layout="position"` cards below reflow through normal document flow, and `initial={false}` skips the mount animation so it renders in its `defaultExpanded` state. - It is a local variant of the core Disclosure rather than a consumer: `Disclosure.Content` hides with `display: none`, which cannot tween and would not reflow the sibling cards, and `Disclosure.Title`'s full-width stretched button cannot express a content-hugging toggle without forking the shared component. - The component has no production consumer in this PR, so it is added to the knip production entry points (see `knip.config.ts`). #117849 removes that exemption when it wires the component into alert frequency. ## Stack - [#117731](#117731): SCM integration selector (merged) - [#117846](#117846): Typography and copy polish (merged) - **PR 3 (this) #117847:** Reusable collapsible section - [#117849](#117849): Alert-frequency collapsible (stacked on this)
sehr-m
pushed a commit
that referenced
this pull request
Jun 23, 2026
…psibleSection (#117849) ## TLDR Applies `ScmCollapsibleSection` to the alert-frequency section of `ScmProjectDetailsCore`, folding it behind a toggle in the project-creation flow. Onboarding keeps the always-expanded header. This is the first production consumer of the component. ## Details - Gated with `collapsible = analyticsFlow === 'project-creation'`. - The chevron and "Alert frequency" title replace the `IconSiren` header, and the "Get notified when things go wrong" subtitle moves into the collapsible body so it hides when collapsed. - Onboarding renders the original `IconSiren` header with an always-expanded body. The body markup is shared between both branches, so onboarding stays visually unchanged. - Removes the knip production-entry exemption that #117847 added for `ScmCollapsibleSection`. Now that the component has a production consumer, the exemption is redundant and would trip knip's config-hint check. ## Stack - [#117731](#117731): SCM integration selector (merged) - [#117846](#117846): Typography and copy polish (merged) - [#117847](#117847): Reusable collapsible section (base of this PR) - **PR 4 (this) #117849:** Alert-frequency collapsible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Applies
ScmCollapsibleSectionto the alert-frequency section ofScmProjectDetailsCore, folding it behind a toggle in the project-creation flow. Onboarding keeps the always-expanded header. This is the first production consumer of the component.Details
collapsible = analyticsFlow === 'project-creation'.IconSirenheader, and the "Get notified when things go wrong" subtitle moves into the collapsible body so it hides when collapsed.IconSirenheader with an always-expanded body. The body markup is shared between both branches, so onboarding stays visually unchanged.ScmCollapsibleSection. Now that the component has a production consumer, the exemption is redundant and would trip knip's config-hint check.Stack