Skip to content

ref(explore): remove explore-schema-hints-removal feature flag #117798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaKGoldberg merged 6 commits into from
Jun 18, 2026
+0 −2
Merged

ref(explore): remove explore-schema-hints-removal feature flag #117798

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
67d1667
feat(explore): remove schema hints altogether
JoshuaKGoldberg Jun 15, 2026
e92f656
ref(explore): remove explore-schema-hints-removal feature flag
JoshuaKGoldberg Jun 16, 2026
68f11e9
Merge remote-tracking branch 'origin/master' into remove-schema-hints
JoshuaKGoldberg Jun 16, 2026
389da28
Merge branch 'remove-schema-hints' into remove-schema-hints-flag
JoshuaKGoldberg Jun 16, 2026
b815fae
Merge remote-tracking branch 'origin/master' into remove-schema-hints…
JoshuaKGoldberg Jun 18, 2026
778a91e
rm static/app/views/explore/spans/spansTabSearchSection.spec.tsx, it'…
JoshuaKGoldberg Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/sentry/features/temporary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,6 @@ def register_temporary_features(manager: FeatureManager) -> None:
manager.add("organizations:dynamic-sampling-minimum-sample-rate", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable explore -> errors ui
manager.add("organizations:explore-errors", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable removing the schema hints section to declutter the explore UI
manager.add("organizations:explore-schema-hints-removal", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
Comment on lines -104 to -105

@shellmayr shellmayr Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flag looks like it's still used in the frontend?

@JoshuaKGoldberg JoshuaKGoldberg Jun 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yip, see the linked #117717 - this PR's into that PR's branch.

@shellmayr shellmayr Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, apologies, didn't see that

# Enable returning the migrated discover queries in explore saved queries
manager.add("organizations:expose-migrated-discover-queries", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable GenAI features such as Autofix and Issue Summary
Expand Down
18 changes: 1 addition & 17 deletions static/app/components/performance/spanSearchQueryBuilder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type {CaseInsensitive} from 'sentry/components/searchQueryBuilder/hooks';
import type {CallbackSearchState} from 'sentry/components/searchQueryBuilder/types';
import type {PageFilters} from 'sentry/types/core';
import type {TagCollection} from 'sentry/types/group';
import {FieldKind, type AggregationKey} from 'sentry/utils/fields';
import {type AggregationKey} from 'sentry/utils/fields';
import {
useTraceItemSearchQueryBuilderProps,
type TraceItemSearchQueryBuilderProps,
Expand All @@ -15,22 +15,6 @@ import {useSpanItemAttributes} from 'sentry/views/explore/hooks/useTraceItemAttr
import {TraceItemDataset} from 'sentry/views/explore/types';
import {SpanFields} from 'sentry/views/insights/types';

export const getFunctionTags = (supportedAggregates?: AggregationKey[]) => {
if (!supportedAggregates?.length) {
return {};
}

return supportedAggregates.reduce((acc, item) => {
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
acc[item] = {
key: item,
name: item,
kind: FieldKind.FUNCTION,
};
return acc;
}, {});
};

export interface UseSpanSearchQueryBuilderProps {
initialQuery: string;
searchSource: string;
Expand Down
334 changes: 0 additions & 334 deletions static/app/views/explore/components/schemaHints/schemaHintsDrawer.tsx
View file
Open in desktop

This file was deleted.

Loading
Loading