-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(dynamic-sampling): Add per-project sample rate override for custom DS #117796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shellmayr
merged 4 commits into
master
from
shellmayr/tet-2490-dynamic-sampling-sample-rate-override
Jun 17, 2026
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
07d2e15
feat(dynamic-sampling): Add per-project sample rate override for cust…
shellmayr f7d2eb4
test(dynamic-sampling): Cover old-path sample rate override and AM3 o…
shellmayr fd01794
test(dynamic-sampling): Drop unrelated AM3 org-mode sample rate tests
shellmayr 7db4245
perf(dynamic-sampling): Read sample rate overrides option once per batch
shellmayr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from sentry import options | ||
|
|
||
|
|
||
| def get_sample_rate_override_for_project(project_id: int) -> float | None: | ||
| """ | ||
| Return a per-project sample rate override for custom dynamic sampling, if one is | ||
| configured via the ``dynamic-sampling.sample-rate-override-per-project`` option. | ||
|
|
||
| The option maps a stringified project id to a fixed sample rate that hard-replaces | ||
| whatever rate the custom dynamic sampling path would otherwise compute. Returns | ||
| ``None`` when no override applies (no entry, or an out-of-range/invalid value, which | ||
| we ignore rather than emit an invalid rule). | ||
| """ | ||
| overrides = options.get("dynamic-sampling.sample-rate-override-per-project") | ||
| raw = overrides.get(str(project_id)) | ||
| if raw is None: | ||
| return None | ||
|
|
||
| try: | ||
| rate = float(raw) | ||
| except (TypeError, ValueError): | ||
| return None | ||
|
|
||
| if 0.0 <= rate <= 1.0: | ||
| return rate | ||
| return None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.