[DO NOT MERGE] ref(sdk): Send internal events only to sentry-mirror#117794
Draft
alexander-alderman-webb wants to merge 11 commits into
Draft
[DO NOT MERGE] ref(sdk): Send internal events only to sentry-mirror#117794alexander-alderman-webb wants to merge 11 commits into
sentry-mirror#117794alexander-alderman-webb wants to merge 11 commits into
Conversation
sentry-mirror
sentry-mirrorsentry-mirror
markstory
reviewed
Jun 17, 2026
markstory
left a comment
Member
There was a problem hiding this comment.
Great to see this moving forward 👏
| sentry4sentry=sdk_options.pop("dsn", None), | ||
| sentry_saas=sdk_options.pop("relay_dsn", None), | ||
| ) | ||
| dsn = sdk_options.pop("sentry_mirror_dsn", None) |
Member
There was a problem hiding this comment.
Any reason to not use dsn as the key? Self-hosted, local development, and single-tenants don't use mirrors.
Contributor
Author
There was a problem hiding this comment.
I can't remember, which means I changed it to dsn now 😄
2d9fd64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send events only to
dsn, and stop reading therelay_dsnoption entirely. Remove multiplexing logic that sends events to multiple DSNs.These options are not parsed anymore:
store.use-relay-dsn-sample-ratestore.allow-s4s-ddm-sample-ratestore.s4s-transaction-sample-rate