ref(seer): Rewrite AutofixRepositories using the new /seer/repos/ endpoints by ryan953 · Pull Request #117740 · getsentry/sentry

ryan953 · 2026-06-15T20:43:29Z

This meant adding a includeInstructions prop to the new version, which revealed that the inputs needed to be debounced. apparently saving a default-branch name before was problematic

With instructions added

Note: these were originally stacked into #117618 and #117630 but i messed that up somehow to update things on master. So now they're together and ready to go. No changes made since before.

This meant adding a `includeInstructions` prop to the new version, which revealed that the inputs needed to be debounced. apparently saving a default-branch name before was problematic

… component Adapt test assertions after the AutofixRepositories refactor: - Add preference.repositories to mock data (component now uses preference instead of code_mapping_repos for the repo list) - Update button labels: 'Add Repos' -> 'Add Repositories to Project', 'Remove Repository' -> 'Disconnect Repository' - Remove explicit Save button click in update test (component now auto-saves via debounce) - Use objectContaining matchers for flexible POST payload assertions Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>

…points

github-actions · 2026-06-15T20:49:49Z

📊 Type Coverage Diff

Metric	Before	After	Delta
Coverage	93.70%	93.70%	±0%
Typed	133,020	132,935	🔴 -85
Untyped	8,942	8,941	🟢 -1

🔍 1 new type safety issue introduced

Non-null assertions (!) (1 new)

File	Line	Detail
`static/app/components/seer/legacy/addAutofixRepoModal.tsx`	166	`filteredRepositories[virtualItem.index]!`

This is informational only and does not block the PR.

github-actions · 2026-06-15T21:05:44Z

Story previews

Preview the stories changed in this PR on the Vercel deployment:

app/components/seer/projectDetails/autofixRepositoriesList.stories.tsx

_{Preview deployment: https://sentry-ddxxl5tqy.sentry.dev}

The onSettled callback was passing an array of query keys (from .map()) as the queryKey option, creating a nested array that TanStack Query could never match. Loop and invalidate each repo's key individually.

The AutofixRepositoriesList component now fetches repos from GET /seer/repos/ and mutates via POST/PUT/DELETE on the same endpoint, instead of going through POST /seer/preferences/. - Add GET /seer/repos/ mock in beforeEach and all clearMockResponses() tests - Update 'can add' test to assert POST /seer/repos/ - Update 'can update' test to assert PUT /seer/repos/:id/ - Update 'can remove' test to assert DELETE /seer/repos/:id/

The frontend used split('/') without a limit, which breaks GitLab subgroup repos (e.g. "Org / Subgroup / Repo") by only capturing the second segment as the name. Use indexOf + slice to match the backend's split("/", 1) behavior in _serialize_project_repo(). See: src/sentry/seer/endpoints/project_seer_repos.py

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5e6d47d. Configure here.}

cursor · 2026-06-15T22:19:28Z

+      onChangeDebounceMs: 1000,
+      onChange: ({formApi}) => formApi.handleSubmit(),
+    },
+    onSubmit: ({value}) => handleUpdateRepo(repoSchema.parse(value)),


Incomplete overrides block autosave

Medium Severity

Debounced autosave validates the whole branchOverrides array before submit. A partially filled override row fails overrideItemSchema, so handleSubmit never runs and completed overrides or edits to other rows are not persisted until every draft row is valid or removed.

^{Reviewed by Cursor Bugbot for commit 5e6d47d. Configure here.}

disagree. I can see that autosave works.

…m to fix nested form Co-Authored-By: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>

sentry · 2026-06-16T15:42:05Z

+  useEffect(() => {
+    setShowMaxLimitAlert(selectedExternalIds.length >= MAX_REPOS_LIMIT);
+  }, [selectedExternalIds.length]);


Bug: The repository limit alert does not account for existing repositories, causing silent UI blocking when the total limit is reached.
_{Severity: MEDIUM}

Suggested Fix

Update the useEffect hook that sets the showMaxLimitAlert. The condition should be changed to selectedExternalIds.length + hiddenExternalIds.length >= MAX_REPOS_LIMIT to be consistent with the selection-blocking logic in handleToggleRepository.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: static/app/components/seer/legacy/addAutofixRepoModal.tsx#L103-L105 Potential issue: The logic to display a repository limit alert is inconsistent with the logic that enforces the limit. The alert is triggered when `selectedExternalIds.length >= MAX_REPOS_LIMIT`, only considering newly selected repositories. However, the selection is blocked based on `hiddenExternalIds.length + prev.length >= MAX_REPOS_LIMIT`, which includes already-connected repositories. This causes a situation where a user can be blocked from selecting more repositories without any alert or feedback, creating a confusing user experience where clicks have no effect.

…submit Co-Authored-By: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>

…points (#117740) This meant adding a `includeInstructions` prop to the new version, which revealed that the inputs needed to be debounced. apparently saving a default-branch name before was problematic With instructions added <img width="819" height="547" alt="SCR-20260614-lqlb" src="https://github.com/user-attachments/assets/325af416-9b42-4de1-b190-f8bc874ecd79" /> Note: these were originally stacked into #117618 and #117630 but i messed that up somehow to update things on master. So now they're together and ready to go. No changes made since before. --------- Co-authored-by: Claude Opus 4 <noreply@anthropic.com> Co-authored-by: Ryan Albrecht <ryan953@MLHJDQR9VJ.local> Co-authored-by: billy <billy@sentry.io> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 15, 2026

vercel Bot had a problem deploying to Preview June 15, 2026 20:44 Failure

ryan953 and others added 3 commits June 15, 2026 13:45

ref(seer): Combine AutofixRepositories components into one

97160fd

This meant adding a `includeInstructions` prop to the new version, which revealed that the inputs needed to be debounced. apparently saving a default-branch name before was problematic

ref(seer): Rewrite AutofixRepositories using the new /seer/repos/ end…

f0050e8

…points

ryan953 force-pushed the ryan953/ref-autofix-repos branch from 094b0fe to f0050e8 Compare June 15, 2026 20:45

vercel Bot had a problem deploying to Preview June 15, 2026 20:47 Failure

billyvg approved these changes Jun 15, 2026

View reviewed changes

add in the missing isntructions textarea, and tidy things

dfef839

vercel Bot deployed to Preview June 15, 2026 21:05 View deployment

ryan953 marked this pull request as ready for review June 15, 2026 21:09

ryan953 requested review from a team as code owners June 15, 2026 21:09

remove unused export of BranchOverride

b067ee1

cursor Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread static/gsApp/views/seerAutomation/onboarding/onboardingLegacy.tsx Outdated

Comment thread static/app/components/seer/legacy/addAutofixRepoModal.tsx

Comment thread static/app/components/seer/legacy/addAutofixRepoModal.tsx Outdated

vercel Bot deployed to Preview June 15, 2026 21:12 View deployment

sentry Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread static/app/components/seer/legacy/addAutofixRepoModal.tsx Outdated

Comment thread static/app/utils/seer/seerProjectRepos.ts Outdated

Comment thread static/app/components/seer/legacy/addAutofixRepoModal.tsx Outdated

ryan953 enabled auto-merge (squash) June 15, 2026 21:15

Merge branch 'master' into ryan953/ref-autofix-repos

d295dbc

cursor Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread static/app/components/seer/projectDetails/autofixRepositoriesList.tsx

vercel Bot deployed to Preview June 15, 2026 21:24 View deployment

ryan953 disabled auto-merge June 15, 2026 21:25

sentry Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread static/app/utils/seer/seerProjectRepos.ts

Comment thread static/app/utils/seer/seerProjectRepos.ts Outdated

ryan953 added 3 commits June 15, 2026 14:27

Fix "Onboarding drops existing repositories" bot review

900ea1a

Fix "Repository limit no longer enforced" bot review comment

9a44a29

fix not-found error and select alignment in the modal

6965a3f

ryan953 added 3 commits June 15, 2026 14:35

fix(seer): Fix silent invalidateQueries no-op in addRepo mutation

432ffa3

The onSettled callback was passing an array of query keys (from .map()) as the queryKey option, creating a nested array that TanStack Query could never match. Loop and invalidate each repo's key individually.

fix "Done triggers empty repo POST" bot review comment

f054409

Merge branch 'master' into ryan953/ref-autofix-repos

d2fd488

sentry Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread static/app/components/seer/legacy/addAutofixRepoModal.tsx

ryan953 force-pushed the ryan953/ref-autofix-repos branch from b857bbe to 212cdc2 Compare June 15, 2026 22:10

vercel Bot deployed to Preview June 15, 2026 22:12 View deployment

sentry Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread static/app/components/seer/projectDetails/autofixRepositoriesItem.tsx

Comment thread static/app/components/seer/projectDetails/autofixRepositoriesList.tsx

Comment thread static/app/components/seer/legacy/addAutofixRepoModal.tsx

vercel Bot deployed to Preview June 15, 2026 22:19 View deployment

cursor Bot reviewed Jun 15, 2026

View reviewed changes

sentry Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread static/app/components/seer/legacy/addAutofixRepoModal.tsx

Comment thread static/app/components/seer/legacy/addAutofixRepoModal.tsx

fix(seer): restore 'Default branch' placeholder casing

ad8b2b3

vercel Bot deployed to Preview June 15, 2026 22:57 View deployment

sentry Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread static/app/components/seer/projectDetails/autofixRepositoriesList.tsx

fix(seer): move instructions AutoSaveForm outside branchOverrides for…

3c4adec

…m to fix nested form Co-Authored-By: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>

vercel Bot deployed to Preview June 16, 2026 15:13 View deployment

🛠️ apply pre-commit fixes

074c94e

sentry Bot reviewed Jun 16, 2026

View reviewed changes

Comment thread static/app/components/seer/legacy/addAutofixRepoModal.tsx Outdated

Count hiddenExternalIds.length + prev.length against MAX_REPOS_LIMIT

8a15aa9

ryan953 enabled auto-merge (squash) June 16, 2026 15:38

vercel Bot deployed to Preview June 16, 2026 15:40 View deployment

sentry Bot reviewed Jun 16, 2026

View reviewed changes

fix(seer): add tab/blur after typing in test to trigger AutoSaveForm …

7674acf

…submit Co-Authored-By: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>

ryan953 merged commit 166db99 into master Jun 16, 2026
75 checks passed

ryan953 deleted the ryan953/ref-autofix-repos branch June 16, 2026 15:59

vercel Bot deployed to Preview June 16, 2026 16:04 View deployment

ryan953 mentioned this pull request Jun 16, 2026

Seer Autofix: unable to delete repository from connected repositories #117489

Closed

Uh oh!

Uh oh!

Conversation

ryan953 commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Type Coverage Diff

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Story previews

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jun 15, 2026

Choose a reason for hiding this comment

Incomplete overrides block autosave

Uh oh!

ryan953 Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sentry Bot Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ryan953 commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading