Skip to content

ref(seer): Remove unused seer-code-review-gitlab feature flag#117737

Merged
billyvg merged 1 commit into
masterfrom
billyvg/ref/remove-seer-code-review-gitlab-flag
Jun 22, 2026
Merged

ref(seer): Remove unused seer-code-review-gitlab feature flag#117737
billyvg merged 1 commit into
masterfrom
billyvg/ref/remove-seer-code-review-gitlab-flag

Conversation

@billyvg

@billyvg billyvg commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to #117732. Now that the GitLab code review webhook flow gates on organizations:seer-gitlab-support, the organizations:seer-code-review-gitlab flag is no longer read anywhere in the codebase. This removes its registration from the feature manager.

Changes

  • Remove the manager.add("organizations:seer-code-review-gitlab", ...) registration (and its comment) from src/sentry/features/temporary.py.

Notes

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 15, 2026
Base automatically changed from billyvg/ref/seer-gitlab-support-flag-consolidation to master June 15, 2026 20:59
@billyvg billyvg force-pushed the billyvg/ref/remove-seer-code-review-gitlab-flag branch 2 times, most recently from b9dfc35 to 1bc6e3b Compare June 16, 2026 14:40
@billyvg billyvg marked this pull request as ready for review June 16, 2026 14:40
@billyvg billyvg requested a review from cmanallen June 16, 2026 14:40
GitLab code review gating now uses organizations:seer-gitlab-support, so
the organizations:seer-code-review-gitlab flag is no longer read anywhere.
Deregister it from the feature manager.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@billyvg billyvg force-pushed the billyvg/ref/remove-seer-code-review-gitlab-flag branch from 1bc6e3b to a891576 Compare June 16, 2026 18:12
@billyvg billyvg merged commit c9753a1 into master Jun 22, 2026
86 checks passed
@billyvg billyvg deleted the billyvg/ref/remove-seer-code-review-gitlab-flag branch June 22, 2026 15:00
sehr-m pushed a commit that referenced this pull request Jun 23, 2026
## Summary

Follow-up to #117732. Now that the GitLab code review webhook flow gates
on `organizations:seer-gitlab-support`, the
`organizations:seer-code-review-gitlab` flag is no longer read anywhere
in the codebase. This removes its registration from the feature manager.

## Changes

- Remove the `manager.add("organizations:seer-code-review-gitlab", ...)`
registration (and its comment) from `src/sentry/features/temporary.py`.

## Notes

- **Stacked on #117732** — that PR removes all reads of the flag; this
PR deregisters it. Merge #117732 first.
- Before this lands, any FlagPole rollout config keyed on
`seer-code-review-gitlab` in `sentry-options-automator` should be
cleaned up, since the flag will no longer resolve.
(getsentry/sentry-options-automator#8260)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants