ref(explore): remove frontend schema hints code#117717
Merged
Merged
Conversation
github-actions
Bot
added
Scope: Frontend
This comment was marked as outdated.
This comment was marked as outdated.
JoshuaKGoldberg
force-pushed
the
remove-schema-hints
branch
from
ccea522 to
67d1667
Compare
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
changed the title
# Conflicts: # static/app/views/explore/conversations/overview.tsx
Removes the orphaned 'schema hints' describe block in spansTab.spec.tsx (its 'See full list' assertion no longer holds after the hints UI was removed) and the now-unemitted schema_hints_click / schema_hints_drawer analytics events.
nikkikapadia
approved these changes
Jun 16, 2026
nikkikapadia
left a comment
nikkikapadia
left a comment
Member
There was a problem hiding this comment.
rip my baby (also a couple of comments)
Comment on lines
-13
to
-22
| const COMMON_HINT_KEYS = [ | ||
| SpanFields.IS_TRANSACTION, | ||
| SpanFields.SPAN_OP, | ||
| SpanFields.SPAN_DESCRIPTION, | ||
| SpanFields.SPAN_DURATION, | ||
| SpanFields.TRANSACTION, | ||
| FieldKey.HTTP_STATUS_CODE, | ||
| SpanFields.RELEASE, | ||
| 'url', | ||
| ]; |
Member
There was a problem hiding this comment.
i wonder if it's worth putting in a suggested/recommended section in the search bar dropdown since we're getting rid of the common ones and they're buried within the other attributes 🤔 not really blocking just a suggestion for down the line
Member
Author
There was a problem hiding this comment.
Yeah I like that! I actually am unclear on (haven't dug into) what the logic is for generating the suggested ones beyond recents...
JoshuaKGoldberg
added a commit
that referenced
this pull request
Jun 18, 2026
Backend half of #117717. Removes the `organizations:explore-schema-hints-removal` feature flag registration now that the schema hints UI is being removed altogether. Closes LOGS-789.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔪🔪🔪 code removal! Now that the full schema hints removal flag is rolled out to GA (https://github.com/getsentry/sentry-options-automator/pull/8249), this removes the frontend schema hints code.
Followup PR to remove the backend feature flag registration: #117798
Does most of LOGS-789.