ref(producers): clean up issues TaskProducers#117686
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 33bdf82. Configure here.
| else SingletonProducer( | ||
| _get_attribute_snapshot_producer, | ||
| max_futures=settings.SENTRY_GROUP_ATTRIBUTES_FUTURES_MAX_LIMIT, | ||
| ) |
There was a problem hiding this comment.
Import-time task producer selection
High Severity
_attribute_snapshot_producer is chosen once at import using settings.TASKWORKER_USE_TASK_PRODUCER. sentry.issues loads this module in AppConfig.ready() during configure(), before taskworker bootstrap sets that flag to True, so taskworker processes can keep a SingletonProducer for snapshot Kafka writes even when they should use TaskProducer.
Reviewed by Cursor Bugbot for commit 33bdf82. Configure here.
There was a problem hiding this comment.
This is valid, so I'll have to rethink how selecting the producer backend should work.
IMO ideally we'd just have a single producer we could use in both taskworker and non-taskworker processes.
33bdf82 to
1551d10
Compare


Followup to #117081, #117107, #117360
TaskProduceris fully rolled out to the above producers in all regions. This PR removes the options controlling rollout and cleans up producer instantiation so we only have 1 producer running in a process (eitherSingletonProducerorTaskProducerbased on what process is running).