fix(devserver): exclude .artifacts from granian reload watcher#117609
Merged
trevor-e merged 1 commit intoJun 15, 2026
Merged
Conversation
Granian's watchfiles-based reloader watches the entire repo directory by default. The TeeStream introduced in getsentry#117486 writes all honcho output to .artifacts/dev.log inside the repo root, which triggered an infinite reload cycle: server logs → dev.log updated → watchfiles detects change → granian reloads → repeat. Fix by passing reload_ignore_dirs=[".artifacts"] to Granian so watchfiles skips that directory. The option is surfaced through the existing options dict so it can be overridden via SENTRY_WEB_OPTIONS if needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
trevor-e
approved these changes
Jun 15, 2026
trevor-e
added
the
Trigger: getsentry tests
Member
|
Thanks for noticing + fixing! Going ahead and merging this in. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes getsentry/self-hosted#4379
Granian's watchfiles-based reloader watches the entire repo directory by default. The TeeStream introduced in #117486 writes all honcho output to .artifacts/dev.log inside the repo root, which triggered an infinite reload cycle: server logs →-> dev.log updated -> watchfiles detects change -> granian reloads -> repeat.
Fix by passing reload_ignore_dirs=[".artifacts"] to Granian so watchfiles skips that directory. The option is surfaced through the existing options dict so it can be overridden via SENTRY_WEB_OPTIONS if needed.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.