feat(span buffer): Add span-first slow DB span detector#117551
Open
lobsterkatie wants to merge 9 commits into
Open
feat(span buffer): Add span-first slow DB span detector#117551lobsterkatie wants to merge 9 commits into
lobsterkatie wants to merge 9 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
lobsterkatie
force-pushed
the
kmclb-add-span-first-slow-db-span-detector
branch
5 times, most recently
from
1790b1a to
98ee840
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
lobsterkatie
force-pushed
the
kmclb-add-span-first-slow-db-span-detector
branch
from
98ee840 to
9dfb9af
Compare
| from sentry.issues.grouptype import GroupType | ||
|
|
||
|
|
||
| class SpanFirstDetector(ABC): |
Member
There was a problem hiding this comment.
is there a spec or something that explains why we are creating a new class for span first detectors vs updating the existing ones to also support span first?
Member
Author
There was a problem hiding this comment.
Mostly because Matt and I agreed that adding a bunch of conditionals into the existing detectors would end up being a lot messier and more work to clean up compared to making new versions which are span-native. It also mirrors what happened for all of the rest of the code called by _process_segment. It duplicates the parts of save_transaction_events which still apply, rather than trying to add conditionals into whatever helpers save_transaction_events calls.
lobsterkatie
force-pushed
the
kmclb-add-span-first-slow-db-span-detector
branch
from
9dfb9af to
976c985
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a first step to converting all of our performance detectors to work with the span buffer, this adds a span-first version of the slow DB span detector, along with span-first versions of some of our testing utils. Note that nothing yet runs this detector - that will come in a follow-up PR. (Update: That PR is here.)