Skip to content

fix(seer-infra-telemetry): Add Datadog site allowlist to identity provider#117541

Merged
shashjar merged 16 commits into
masterfrom
shashjar/add-datadog-site-allowlist-validation
Jun 16, 2026
Merged

fix(seer-infra-telemetry): Add Datadog site allowlist to identity provider#117541
shashjar merged 16 commits into
masterfrom
shashjar/add-datadog-site-allowlist-validation

Conversation

@shashjar

@shashjar shashjar commented Jun 12, 2026

Copy link
Copy Markdown
Member

Follow-up to #117854.

Adds an allowlist of valid Datadog site domains (DATADOG_VALID_SITES) to the DatadogIdentityProvider, in order to validate that the site POST body parameter is an actual valid Datadog site to trigger an OAuth flow with and use as the MCP base URL.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2026
@shashjar shashjar requested review from srest2021 and wedamija June 15, 2026 23:22
@shashjar shashjar marked this pull request as ready for review June 15, 2026 23:22
@shashjar shashjar requested review from a team as code owners June 15, 2026 23:22
@shashjar shashjar removed request for a team June 15, 2026 23:22
Comment thread src/sentry/identity/datadog/provider.py
Base automatically changed from shashjar/add-monitoring-provider-connection-API-endpoints to master June 16, 2026 19:59
@shashjar shashjar requested a review from a team as a code owner June 16, 2026 19:59

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 53d7bed. Configure here.

Comment thread src/sentry/identity/datadog/provider.py
@shashjar shashjar merged commit 3cae38e into master Jun 16, 2026
65 checks passed
@shashjar shashjar deleted the shashjar/add-datadog-site-allowlist-validation branch June 16, 2026 21:31
billyvg pushed a commit that referenced this pull request Jun 17, 2026
…vider (#117541)

Follow-up to #117478.

Adds an allowlist of valid Datadog site domains (`DATADOG_VALID_SITES`)
to the `DatadogIdentityProvider`, in order to validate that the `site`
POST body parameter is an actual valid Datadog site to trigger an OAuth
flow with and use as the MCP base URL.

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants